Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed gauss_fir to work with numpy-2 #1150

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

yarda
Copy link
Contributor

@yarda yarda commented Jan 9, 2025

It's related to #1149

@andynoack
Copy link
Collaborator

I have fixed the CI pipeline (macos-12) in the master branch now.

@yarda
Copy link
Contributor Author

yarda commented Jan 14, 2025

I have fixed the CI pipeline (macos-12) in the master branch now.

Could you restart the CI? IMHO the failure is unrelated to the PR.

@yarda
Copy link
Contributor Author

yarda commented Jan 14, 2025

Context of the proposed PR:
The problem observed is related to the numpy-2 change in data type promotion, which is now according to the NEP 50, i.e. the float_32 was promoted to float_64 which maps to the C type double which causes the gauss_fir to traceback. The proposed change is compatible with numpy-1.

@andynoack
Copy link
Collaborator

I have fixed the CI pipeline (macos-12) in the master branch now.

Could you restart the CI? IMHO the failure is unrelated to the PR.

You have to pull the CI fix first, at the moment the CI is based on the old config.

@yarda
Copy link
Contributor Author

yarda commented Jan 14, 2025

You have to pull the CI fix first, at the moment the CI is based on the old config.

OK, NP, thanks for the info, I will rebase it.

It's related to jopohl#1149

Signed-off-by: Jaroslav Škarvada <jskarvad@redhat.com>
@yarda yarda force-pushed the numpy2-gauss-fir-fix branch from 7e2d831 to d82004c Compare January 14, 2025 11:03
@andynoack andynoack merged commit 0f9365b into jopohl:master Jan 14, 2025
10 checks passed
@yarda yarda deleted the numpy2-gauss-fir-fix branch January 14, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants