Skip to content

Commit

Permalink
Warn about reloading dependencies after downloading models (explosion…
Browse files Browse the repository at this point in the history
…#13081)

* Update the "Missing factory" error message

This accounts for model installations that took place during the current Python session.

* Add a note about Jupyter notebooks

* Move error to `spacy.cli.download`
Add extra message for Jupyter sessions

* Add additional note for interactive sessions

* Remove note about `spacy-transformers` from error message

* `isort`

* Improve checks for colab (also helps displacy)

* Update warning messages

* Improve flow for multiple checks

---------

Co-authored-by: Adriane Boyd <adrianeboyd@gmail.com>
  • Loading branch information
2 people authored and jikanter committed Mar 29, 2024
1 parent 64bad1c commit a3af2de
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions spacy/cli/download.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,11 @@
from wasabi import msg

from .. import about
from ..errors import OLD_MODEL_SHORTCUTS
from ..util import (
get_installed_models,
get_minor_version,
get_package_version,
is_in_interactive,
is_in_jupyter,
is_package,
is_prerelease_version,
run_command,
Expand Down

0 comments on commit a3af2de

Please sign in to comment.