Refactor

jordanmontt · Sep 22, 2023 · d859972 · d859972
1 parent acdb6e9
commit d859972
Show file tree

Hide file tree

Showing 36 changed files with 110 additions and 90 deletions.
diff --git a/src/BaselineOfIllimaniProfiler/BaselineOfIllimaniProfiler.class.st b/src/BaselineOfIllimaniProfiler/BaselineOfIllimaniProfiler.class.st
@@ -14,18 +14,12 @@ BaselineOfIllimaniProfiler >> baseline: spec [
 	<baseline>
 	spec for: #common do: [
 		"Packages"
-		spec package: 'IllimaniKernel'
+		spec package: 'IllimaniProfiler'
 			with: [ spec requires: #( 'MethodProxies' ) ].
-		spec package: 'IllimaniAllocationProfiler'
-			with: [ spec requires: #( 'IllimaniKernel' 'MethodProxies' ) ].
-		spec package: 'IllimaniFinalizationProfiler'
-			with: [ spec requires: #( 'IllimaniKernel' 'IllimaniAllocationProfiler' 'MethodProxies' ) ].
 		spec package: 'IllimaniUI'
-			with: [ spec requires: #( 'IllimaniAllocationProfiler' 'IllimaniFinalizationProfiler' ) ].
-		spec package: 'IllimaniAllocationProfiler-Tests'
-			with: [ spec requires: #( 'IllimaniAllocationProfiler' ) ].
-		spec package: 'IllimaniFinalizationProfiler-Tests'
-			with: [ spec requires: #( 'IllimaniFinalizationProfiler' ) ].
+			with: [ spec requires: #( 'IllimaniProfiler' ) ].
+		spec package: 'IllimaniProfiler-Tests'
+			with: [ spec requires: #( 'IllimaniProfiler' ) ].
 
 		"External dependencies"
 		spec baseline: 'MethodProxies'
@@ -45,7 +39,7 @@ BaselineOfIllimaniProfiler >> baseline: spec [
 		"Groups"
 		spec group: 'default' with: #( 'core' 'tests' ).
 		spec group: 'core'
-			with: #( 'IllimaniAllocationProfiler' 'IllimaniUI' 'IllimaniFinalizationProfiler' 'IllimaniKernel' ).
+			with: #( 'IllimaniProfiler' 'IllimaniUI' ).
 		spec group: 'tests'
-			with: #( 'IllimaniAllocationProfiler-Tests' 'IllimaniFinalizationProfiler-Tests' ) ]
+			with: #( 'IllimaniProfiler-Tests' ) ]
 ]
diff --git a/src/IllimaniAllocationProfiler-Tests/package.st b/src/IllimaniAllocationProfiler-Tests/package.st
diff --git a/src/IllimaniAllocationProfiler/package.st b/src/IllimaniAllocationProfiler/package.st
diff --git a/src/IllimaniFinalizationProfiler-Tests/package.st b/src/IllimaniFinalizationProfiler-Tests/package.st
diff --git a/src/IllimaniFinalizationProfiler/package.st b/src/IllimaniFinalizationProfiler/package.st
diff --git a/src/IllimaniKernel/IllAnnouncer.class.st b/src/IllimaniKernel/IllAnnouncer.class.st
diff --git a/src/IllimaniKernel/IllStopedProfilingAnnouncement.class.st b/src/IllimaniKernel/IllStopedProfilingAnnouncement.class.st
diff --git a/src/IllimaniKernel/package.st b/src/IllimaniKernel/package.st
diff --git a/...r-Tests/AllocationStatisticsTest.class.st → ...r-Tests/AllocationStatisticsTest.class.st b/...r-Tests/AllocationStatisticsTest.class.st → ...r-Tests/AllocationStatisticsTest.class.st
@@ -8,9 +8,9 @@ Class {
 		'fixture',
 		'statsModel'
 	],
-	#category : 'IllimaniAllocationProfiler-Tests-Statistics-Model',
-	#package : 'IllimaniAllocationProfiler-Tests',
-	#tag : 'Statistics-Model'
+	#category : 'IllimaniProfiler-Tests-Model-Statistics',
+	#package : 'IllimaniProfiler-Tests',
+	#tag : 'Model-Statistics'
 }
 
 { #category : 'running' }

diff --git a/.../AllocationStatisticsTestFixture.class.st → .../AllocationStatisticsTestFixture.class.st b/.../AllocationStatisticsTestFixture.class.st → .../AllocationStatisticsTestFixture.class.st
@@ -9,9 +9,9 @@ Class {
 		'groupedAndSortedByMethodAllocations',
 		'mockedAllocations'
 	],
-	#category : 'IllimaniAllocationProfiler-Tests-Statistics-Model',
-	#package : 'IllimaniAllocationProfiler-Tests',
-	#tag : 'Statistics-Model'
+	#category : 'IllimaniProfiler-Tests-Model-Statistics',
+	#package : 'IllimaniProfiler-Tests',
+	#tag : 'Model-Statistics'
 }
 
 { #category : 'fixture' }

diff --git a/...-Tests/IllAllocationProfilerTest.class.st → ...-Tests/IllAllocationProfilerTest.class.st b/...-Tests/IllAllocationProfilerTest.class.st → ...-Tests/IllAllocationProfilerTest.class.st
@@ -4,9 +4,9 @@ Class {
 	#instVars : [
 		'illimani'
 	],
-	#category : 'IllimaniAllocationProfiler-Tests-Profiler',
-	#package : 'IllimaniAllocationProfiler-Tests',
-	#tag : 'Profiler'
+	#category : 'IllimaniProfiler-Tests-Allocations-Profiler',
+	#package : 'IllimaniProfiler-Tests',
+	#tag : 'Allocations-Profiler'
 }
 
 { #category : 'running' }
@@ -60,9 +60,7 @@ IllAllocationProfilerTest >> testProfileOnSimpleMoreAllocations [
 
 	self assert: illimani objectAllocations size > 1000.
 	illimani objectAllocations do: [ :alloc |
-		self assert: alloc allocatedObjectClass isClass.
-		"Stack was copied"
-		self assert: alloc context class equals: Context ]
+		self assert: alloc allocatedObjectClass isClass ]
 ]
 
 { #category : 'tests' }

diff --git a/...ests/IllFinalizationProfilerTest.class.st → ...ests/IllFinalizationProfilerTest.class.st b/...ests/IllFinalizationProfilerTest.class.st → ...ests/IllFinalizationProfilerTest.class.st
@@ -4,9 +4,9 @@ Class {
 	#instVars : [
 		'finalizationProfiler'
 	],
-	#category : 'IllimaniFinalizationProfiler-Tests-Tests',
-	#package : 'IllimaniFinalizationProfiler-Tests',
-	#tag : 'Tests'
+	#category : 'IllimaniProfiler-Tests-Finalization-Profiler',
+	#package : 'IllimaniProfiler-Tests',
+	#tag : 'Finalization-Profiler'
 }
 
 { #category : 'running' }

diff --git a/...filerUnconstructedCollectionTest.class.st → ...filerUnconstructedCollectionTest.class.st b/...filerUnconstructedCollectionTest.class.st → ...filerUnconstructedCollectionTest.class.st
@@ -4,9 +4,9 @@ Class {
 	#instVars : [
 		'profiler'
 	],
-	#category : 'IllimaniFinalizationProfiler-Tests-Tests',
-	#package : 'IllimaniFinalizationProfiler-Tests',
-	#tag : 'Tests'
+	#category : 'IllimaniProfiler-Tests-Finalization-Profiler',
+	#package : 'IllimaniProfiler-Tests',
+	#tag : 'Finalization-Profiler'
 }
 
 { #category : 'tests' }

diff --git a/src/IllimaniProfiler-Tests/package.st b/src/IllimaniProfiler-Tests/package.st
@@ -0,0 +1 @@
+Package { #name : 'IllimaniProfiler-Tests' }
diff --git a/...Profiler/AllocationSiteInfoModel.class.st → ...Profiler/AllocationSiteInfoModel.class.st b/...Profiler/AllocationSiteInfoModel.class.st → ...Profiler/AllocationSiteInfoModel.class.st
@@ -7,9 +7,9 @@ Class {
 		'allocatorMethod',
 		'contextFingerprint'
 	],
-	#category : 'IllimaniAllocationProfiler-Model',
-	#package : 'IllimaniAllocationProfiler',
-	#tag : 'Model'
+	#category : 'IllimaniProfiler-Model-Allocation',
+	#package : 'IllimaniProfiler',
+	#tag : 'Model-Allocation'
 }
 
 { #category : 'accessing' }

diff --git a/...onProfiler/AllocationsStatsModel.class.st → ...niProfiler/AllocationsStatsModel.class.st b/...onProfiler/AllocationsStatsModel.class.st → ...niProfiler/AllocationsStatsModel.class.st
@@ -10,9 +10,9 @@ Class {
 		'allocationNodesByMethod',
 		'didIWalk'
 	],
-	#category : 'IllimaniAllocationProfiler-Statistics-Model',
-	#package : 'IllimaniAllocationProfiler',
-	#tag : 'Statistics-Model'
+	#category : 'IllimaniProfiler-Model-Statistics',
+	#package : 'IllimaniProfiler',
+	#tag : 'Model-Statistics'
 }
 
 { #category : 'accessing' }

diff --git a/...rofiler/BasicAllocationInfoModel.class.st → ...rofiler/BasicAllocationInfoModel.class.st b/...rofiler/BasicAllocationInfoModel.class.st → ...rofiler/BasicAllocationInfoModel.class.st
@@ -7,9 +7,9 @@ Class {
 		'finalizationTime',
 		'initializationTime'
 	],
-	#category : 'IllimaniAllocationProfiler-Model',
-	#package : 'IllimaniAllocationProfiler',
-	#tag : 'Model'
+	#category : 'IllimaniProfiler-Model-Allocation',
+	#package : 'IllimaniProfiler',
+	#tag : 'Model-Allocation'
 }
 
 { #category : 'accessing' }

diff --git a/src/IllimaniKernel/Duration.extension.st → src/IllimaniProfiler/Duration.extension.st b/src/IllimaniKernel/Duration.extension.st → src/IllimaniProfiler/Duration.extension.st
@@ -1,6 +1,6 @@
 Extension { #name : 'Duration' }
 
-{ #category : '*IllimaniKernel' }
+{ #category : '*IllimaniProfiler' }
 Duration >> asDeciSeconds [
 
 

diff --git a/...rofiler/FinalizationRegistry.extension.st → ...rofiler/FinalizationRegistry.extension.st b/...rofiler/FinalizationRegistry.extension.st → ...rofiler/FinalizationRegistry.extension.st
@@ -1,6 +1,6 @@
 Extension { #name : 'FinalizationRegistry' }
 
-{ #category : '*IllimaniFinalizationProfiler' }
+{ #category : '*IllimaniProfiler' }
 FinalizationRegistry >> finalizeAllEphemerons [
 
 	| node |

diff --git a/...nProfiler/FinalizationStatsModel.class.st → ...iProfiler/FinalizationStatsModel.class.st b/...nProfiler/FinalizationStatsModel.class.st → ...iProfiler/FinalizationStatsModel.class.st
@@ -4,9 +4,9 @@ Class {
 	#instVars : [
 		'objectAllocations'
 	],
-	#category : 'IllimaniFinalizationProfiler-Profiler',
-	#package : 'IllimaniFinalizationProfiler',
-	#tag : 'Profiler'
+	#category : 'IllimaniProfiler-Model-Statistics',
+	#package : 'IllimaniProfiler',
+	#tag : 'Model-Statistics'
 }
 
 { #category : 'instance creation' }

diff --git a/...AllocationsByAllocatorCollection.class.st → ...AllocationsByAllocatorCollection.class.st b/...AllocationsByAllocatorCollection.class.st → ...AllocationsByAllocatorCollection.class.st
@@ -8,9 +8,9 @@ Class {
 		'sortedByTotalAllocationsNodes',
 		'groupedNodesDictionary'
 	],
-	#category : 'IllimaniAllocationProfiler-Statistics-Model',
-	#package : 'IllimaniAllocationProfiler',
-	#tag : 'Statistics-Model'
+	#category : 'IllimaniProfiler-Model-Statistics',
+	#package : 'IllimaniProfiler',
+	#tag : 'Model-Statistics'
 }
 
 { #category : 'converting' }

diff --git a/...roupedAllocationsByAllocatorNode.class.st → ...roupedAllocationsByAllocatorNode.class.st b/...roupedAllocationsByAllocatorNode.class.st → ...roupedAllocationsByAllocatorNode.class.st
@@ -8,9 +8,9 @@ Class {
 		'allocator',
 		'groupedAllocations'
 	],
-	#category : 'IllimaniAllocationProfiler-Statistics-Model',
-	#package : 'IllimaniAllocationProfiler',
-	#tag : 'Statistics-Model'
+	#category : 'IllimaniProfiler-Model-Statistics',
+	#package : 'IllimaniProfiler',
+	#tag : 'Model-Statistics'
 }
 
 { #category : 'api' }

diff --git a/...limaniKernel/IllAbstractProfiler.class.st → ...maniProfiler/IllAbstractProfiler.class.st b/...limaniKernel/IllAbstractProfiler.class.st → ...maniProfiler/IllAbstractProfiler.class.st
@@ -15,8 +15,9 @@ Class {
 		'totalGCTime',
 		'endOfProfilingTime'
 	],
-	#category : 'IllimaniKernel',
-	#package : 'IllimaniKernel'
+	#category : 'IllimaniProfiler-Instrumentation',
+	#package : 'IllimaniProfiler',
+	#tag : 'Instrumentation'
 }
 
 { #category : 'accessing - statistics' }

diff --git a/...onProfiler/IllAllocationProfiler.class.st → ...niProfiler/IllAllocationProfiler.class.st b/...onProfiler/IllAllocationProfiler.class.st → ...niProfiler/IllAllocationProfiler.class.st
@@ -71,9 +71,9 @@ Class {
 		'classesToAvoidInTheContextSearch',
 		'objectAllocations'
 	],
-	#category : 'IllimaniAllocationProfiler-Profiler',
-	#package : 'IllimaniAllocationProfiler',
-	#tag : 'Profiler'
+	#category : 'IllimaniProfiler-Allocation-Profiler',
+	#package : 'IllimaniProfiler',
+	#tag : 'Allocation-Profiler'
 }
 
 { #category : 'announcements' }

diff --git a/src/IllimaniProfiler/IllAnnouncer.class.st b/src/IllimaniProfiler/IllAnnouncer.class.st
@@ -0,0 +1,7 @@
+Class {
+	#name : 'IllAnnouncer',
+	#superclass : 'Announcer',
+	#category : 'IllimaniProfiler-Instrumentation',
+	#package : 'IllimaniProfiler',
+	#tag : 'Instrumentation'
+}
diff --git a/...inalizationProfiler/IllEphemeron.class.st → src/IllimaniProfiler/IllEphemeron.class.st b/...inalizationProfiler/IllEphemeron.class.st → src/IllimaniProfiler/IllEphemeron.class.st
@@ -8,9 +8,9 @@ Class {
 		'initializationTime',
 		'allocatedObjectClass'
 	],
-	#category : 'IllimaniFinalizationProfiler-Ephemerons',
-	#package : 'IllimaniFinalizationProfiler',
-	#tag : 'Ephemerons'
+	#category : 'IllimaniProfiler-Finalization-Ephemerons',
+	#package : 'IllimaniProfiler',
+	#tag : 'Finalization-Ephemerons'
 }
 
 { #category : 'accessing' }

diff --git a/...Profiler/IllFinalizationProfiler.class.st → ...Profiler/IllFinalizationProfiler.class.st b/...Profiler/IllFinalizationProfiler.class.st → ...Profiler/IllFinalizationProfiler.class.st
@@ -5,9 +5,9 @@ Class {
 		'ephemeronsCollection',
 		'statsModel'
 	],
-	#category : 'IllimaniFinalizationProfiler-Profiler',
-	#package : 'IllimaniFinalizationProfiler',
-	#tag : 'Profiler'
+	#category : 'IllimaniProfiler-Finalization-Profiler',
+	#package : 'IllimaniProfiler',
+	#tag : 'Finalization-Profiler'
 }
 
 { #category : 'profiling' }
@@ -34,7 +34,7 @@ IllFinalizationProfiler >> internalRegisterAllocation: anObject [
 		yourself)
 ]
 
-{ #category : 'api' }
+{ #category : 'accessing' }
 IllFinalizationProfiler >> objectAllocations [
 
 	^ ephemeronsCollection

diff --git a/...Profiler/IllFinalizationRegistry.class.st → ...Profiler/IllFinalizationRegistry.class.st b/...Profiler/IllFinalizationRegistry.class.st → ...Profiler/IllFinalizationRegistry.class.st
@@ -1,9 +1,9 @@
 Class {
 	#name : 'IllFinalizationRegistry',
 	#superclass : 'FinalizationRegistry',
-	#category : 'IllimaniFinalizationProfiler-Ephemerons',
-	#package : 'IllimaniFinalizationProfiler',
-	#tag : 'Ephemerons'
+	#category : 'IllimaniProfiler-Finalization-Ephemerons',
+	#package : 'IllimaniProfiler',
+	#tag : 'Finalization-Ephemerons'
 }
 
 { #category : 'profiling' }

diff --git a/...onUnprocessedAllocationsProfiler.class.st → ...onUnprocessedAllocationsProfiler.class.st b/...onUnprocessedAllocationsProfiler.class.st → ...onUnprocessedAllocationsProfiler.class.st
@@ -7,9 +7,9 @@ Class {
 		'unprocessedFinalizations',
 		'unprocessedAllocations'
 	],
-	#category : 'IllimaniFinalizationProfiler-Profiler',
-	#package : 'IllimaniFinalizationProfiler',
-	#tag : 'Profiler'
+	#category : 'IllimaniProfiler-Finalization-Profiler',
+	#package : 'IllimaniProfiler',
+	#tag : 'Finalization-Profiler'
 }
 
 { #category : 'profiling' }
@@ -103,6 +103,12 @@ IllFinalizationUnprocessedAllocationsProfiler >> stopProfiling [
 	self forceFinalizationOfObjects
 ]
 
+{ #category : 'as yet unclassified' }
+IllFinalizationUnprocessedAllocationsProfiler >> uiClass [
+
+	^ IllFinalizationProfilerUI
+]
+
 { #category : 'accessing' }
 IllFinalizationUnprocessedAllocationsProfiler >> unprocessedAllocations [
 

diff --git a/src/IllimaniKernel/IllMpHandler.class.st → src/IllimaniProfiler/IllMpHandler.class.st b/src/IllimaniKernel/IllMpHandler.class.st → src/IllimaniProfiler/IllMpHandler.class.st
@@ -4,8 +4,9 @@ Class {
 	#instVars : [
 		'profiler'
 	],
-	#category : 'IllimaniKernel',
-	#package : 'IllimaniKernel'
+	#category : 'IllimaniProfiler-Instrumentation',
+	#package : 'IllimaniProfiler',
+	#tag : 'Instrumentation'
 }
 
 { #category : 'evaluating' }

diff --git a/src/IllimaniProfiler/IllStopedProfilingAnnouncement.class.st b/src/IllimaniProfiler/IllStopedProfilingAnnouncement.class.st
@@ -0,0 +1,7 @@
+Class {
+	#name : 'IllStopedProfilingAnnouncement',
+	#superclass : 'Announcement',
+	#category : 'IllimaniProfiler-Announcement',
+	#package : 'IllimaniProfiler',
+	#tag : 'Announcement'
+}
diff --git a/...IllimaniKernel/MpNullMethodProxy.class.st → ...limaniProfiler/MpNullMethodProxy.class.st b/...IllimaniKernel/MpNullMethodProxy.class.st → ...limaniProfiler/MpNullMethodProxy.class.st
@@ -1,8 +1,9 @@
 Class {
 	#name : 'MpNullMethodProxy',
 	#superclass : 'Object',
-	#category : 'IllimaniKernel',
-	#package : 'IllimaniKernel'
+	#category : 'IllimaniProfiler-Instrumentation',
+	#package : 'IllimaniProfiler',
+	#tag : 'Instrumentation'
 }
 
 { #category : 'instance creation' }

diff --git a/src/IllimaniProfiler/package.st b/src/IllimaniProfiler/package.st
@@ -0,0 +1 @@
+Package { #name : 'IllimaniProfiler' }
diff --git a/src/IllimaniUI/IllAbstractProfiler.extension.st b/src/IllimaniUI/IllAbstractProfiler.extension.st
@@ -3,7 +3,13 @@ Extension { #name : 'IllAbstractProfiler' }
 { #category : '*IllimaniUI' }
 IllAbstractProfiler >> open [
 
-	^ (IllAllocationProfilerUI profiler: self announcer: self illimaniAnnouncer)
+	^ (self uiClass profiler: self announcer: self illimaniAnnouncer)
 		  open;
 		  yourself
 ]
+
+{ #category : '*IllimaniUI' }
+IllAbstractProfiler >> uiClass [
+
+	^ self subclassResponsibility
+]
diff --git a/src/IllimaniUI/IllAllocationProfiler.extension.st b/src/IllimaniUI/IllAllocationProfiler.extension.st
@@ -0,0 +1,7 @@
+Extension { #name : 'IllAllocationProfiler' }
+
+{ #category : '*IllimaniUI' }
+IllAllocationProfiler >> uiClass [
+
+	^ IllAllocationProfilerUI
+]