Skip to content

Commit

Permalink
Change default Debian package priority to optional
Browse files Browse the repository at this point in the history
Since Debian Policy version 4.0.1, the "extra" priority has been
deprecated and replaced with "optional"; this triggers Lintian warnings
for Debian packages built by FPM. Make this the new default for Debian
package outputs when no value of --deb-priority is given.

Fixes #1398.
  • Loading branch information
chrisnovakovic authored and jordansissel committed Jun 24, 2022
1 parent 40795d4 commit 9b32d9a
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions lib/fpm/package/deb.rb
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ class FPM::Package::Deb < FPM::Package
end

option "--priority", "PRIORITY",
"The debian package 'priority' value.", :default => "extra"
"The debian package 'priority' value.", :default => "optional"

option "--use-file-permissions", :flag,
"Use existing file permissions when defining ownership and modes"
Expand Down Expand Up @@ -216,7 +216,7 @@ class FPM::Package::Deb < FPM::Package

def initialize(*args)
super(*args)
attributes[:deb_priority] = "extra"
attributes[:deb_priority] = "optional"
end # def initialize

private
Expand Down
4 changes: 2 additions & 2 deletions spec/fpm/package/deb_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,8 @@
end

describe "priority" do
it "should default to 'extra'" do
expect(subject.attributes[:deb_priority]).to(be == "extra")
it "should default to 'optional'" do
expect(subject.attributes[:deb_priority]).to(be == "optional")
end
end

Expand Down

0 comments on commit 9b32d9a

Please sign in to comment.