fix member access issue #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Vijay Sarvepalli <vssarvepalli@cert.org>
jorenbroekema
commented
Dec 7, 2025
|
Thank you so much! I'm all excited about it! |
Collaborator
|
Hello @jorenbroekema I have added some updates and comments for you to review. It will be good for you to review one more time before merging |
Owner
Author
|
Published expr-eval-fork v3.0.1 with the fixes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sei-vsarvepalli @huydoppaz @Mwpereira
Good to release like this? It's a combination of some of the minor improvements by me, the multiple member access fixes by @sei-vsarvepalli and changelog/version bump for NPM release
Please thumbs up / reply to this if you want me to invite you as a contributor, that'll help with getting future issues fixed sooner, I'll prep some CI/CD this week so publishing to NPM is automated, and lint/tests are enforced.