small bug fix

josef-stips · Mar 27, 2024 · 8214dc3 · 8214dc3
1 parent eacf093
commit 8214dc3
Showing 2 changed files with 9 additions and 8 deletions.
diff --git a/src/script/public/App/features/Achievements.js b/src/script/public/App/features/Achievements.js
@@ -193,6 +193,8 @@ class Achievements {
             i_abso.style.alignItems = "center";
             i_abso.style.color = "goldenrod";
 
+            i_abso.classList.add("achievement_check_icon");
+
             let img = document.createElement("img");
             img.src = achievement["img"];
             img.width = "80";
@@ -378,20 +380,18 @@ class Achievements {
         // get achievement with all its data
         let achievement = this.achievements[index];
         // get corresponding list element from achievements list to just add it to the pop up
-        let element = document.querySelector(` [achievement_id = "${index}"]
-                    `);
+        let element = document.querySelector(`[achievement_id="${index}"]`);
         let h2 = document.createElement("h2");
         h2.textContent = "Achievement unlocked!";
 
         newAchievementUnlockedPopUp.textContent = null;
         newAchievementUnlockedPopUp.appendChild(h2);
         newAchievementUnlockedPopUp.appendChild(element.cloneNode(true));
-        newAchievementUnlockedPopUp.querySelector(` [achievement_id = "${index}"]
-                    `).className = "newAchievementContent";
+        newAchievementUnlockedPopUp.querySelector(`[achievement_id="${index}"]`).className = "newAchievementContent";
 
         // delete img element from list element in achievement pop up + manipulate other things
         newAchievementUnlockedPopUp.querySelector("li").querySelector("img").remove();
-        newAchievementUnlockedPopUp.querySelector("li").querySelector("i").remove();
+        newAchievementUnlockedPopUp.querySelector("li").querySelector(".achievement_check_icon").remove();
         newAchievementUnlockedPopUp.querySelector("li").querySelector("div").style.display = "flex";
         newAchievementUnlockedPopUp.querySelector("li").querySelector("div").style.flexDirection = "column";
         newAchievementUnlockedPopUp.querySelector("li").querySelector("div").style.alignItems = "center";
@@ -411,6 +411,7 @@ class Achievements {
         }, 4000);
     };
 };
+
 let Achievement = new Achievements();
 Achievement.Init();
 

diff --git a/src/script/public/Game/processWinner.js b/src/script/public/Game/processWinner.js
@@ -617,9 +617,9 @@ function chooseSubWinner(Player1_won, Player2_won, WinCombination, extra_points)
                 };
 
                 // this commented code is only for test purposes
-                if (curr_mode == GameMode[3].opponent) { // computer mode/ offline mode against a friend
-                    recentUsedPattern_add([...WinCombination].map(el => parseInt(el.getAttribute("cell-index")))); // add used pattern to recently used pattern list
-                };
+                // if (curr_mode == GameMode[3].opponent) { // computer mode/ offline mode against a friend
+                //     recentUsedPattern_add([...WinCombination].map(el => parseInt(el.getAttribute("cell-index")))); // add used pattern to recently used pattern list
+                // };
 
                 Player1_won = false;
                 resolve();