Small performance changes #18
Conversation
3 x faster and fix phpstan error
|
This PR have several changes too. |
| @@ -30,6 +30,7 @@ public function __construct( string $db ) { | |||
| $sql = 'SELECT name FROM sqlite_master WHERE type="table" AND name="storage"'; | |||
| verbose( "SQLite: $sql" ); | |||
| $table_check = self::$db->querySingle( $sql ); | |||
|
|
|||
There was a problem hiding this comment.
There are some extra tabs on this line.
| } else { | ||
| return true; | ||
| } | ||
| return (bool) $query->execute(); |
There was a problem hiding this comment.
I can appreciate removing the if/else combination. However, return should be a simple variable/value instead of an expression. This makes it easier to work with the results of $query->execute() later on, if needed ( like debugging an unexpected behavior ).
|
|
||
| return false; | ||
| return (bool) $query->execute(); |
There was a problem hiding this comment.
Same item here about returning simple values/variables.
| return false; | ||
| } | ||
|
|
||
| $results = $this->set( $key, $flags, $exptime, "{$results[0]['value']}$value" ); | ||
| return $results; | ||
| return $this->set( $key, $flags, $exptime, "{$results[0]['value']}$value" ); |
There was a problem hiding this comment.
Another item here of not returning a simple value/variable.
|
|
||
| return false; | ||
| return ( $query->execute() !== false && self::$db->changes() === 1 ); |
There was a problem hiding this comment.
Only return a simple value/variable.
| return false; | ||
| } | ||
|
|
||
| $results = $this->set( $key, $flags, $exptime, "$value{$results[0]['value']}" ); | ||
| return $results; | ||
| return $this->set( $key, $flags, $exptime, "$value{$results[0]['value']}" ); |
There was a problem hiding this comment.
Only return simple values/variables.
| return false; | ||
| } | ||
|
|
||
| $result = $this->set( $key, $flags, $exptime, $value ); | ||
| return $result; | ||
| return $this->set( $key, $flags, $exptime, $value ); |
There was a problem hiding this comment.
Only return simple values/variables.
|
|
||
| return false; | ||
| return (bool) $query->execute(); |
There was a problem hiding this comment.
Only return simple value/variables.
| @@ -255,29 +220,23 @@ public function stat_curr_items() { | |||
| $result = $query->execute(); | |||
|
|
|||
| if ( $result !== false ) { | |||
| $row = $result->fetchArray( SQLITE3_ASSOC ); | |||
| return $row['curr_items']; | |||
| return $result->fetchArray( SQLITE3_ASSOC ) ['curr_items']; | |||
There was a problem hiding this comment.
Only return simple values/variables.
| return false; | ||
| } | ||
|
|
||
| $result = $this->set( | ||
| return $this->set( |
There was a problem hiding this comment.
Only return simple values/variables.
$this->set()always return bool[] === $resultsis 3 x faster thancount( $results ) === 0, and fix phpstan errorThe methods that return bool,
(bool) SQLite3Result|falseUsed
(bool) $resultbecause is more semantic than($result).Changed type hint return in
get(), always is array.