new(usr): Add first pass at Readwise API V3 (support for Reader) #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that this is clearly still in beta (liable to change) because there are cases where the docs don't match the data (e.g. `published_date`). Addresses #1
andyw8
reviewed
Mar 5, 2024
| :parent_id, # both highlights and notes made in Reader are also considered Documents. | ||
| # Highlights and notes will have `parent_id` set, which is the Document id | ||
| # of the article/book/etc and highlight that they belong to, respectively. | ||
| keyword_init: true |
There was a problem hiding this comment.
btw if you can choose to only support Ruby 3.2 or newer then it defaults to keyword_init.
There was a problem hiding this comment.
🤷🏼 It's not that burdensome to keep around. Ruby 3.0 isn't EOL until next year, I think.
joshbeckman
commented
Mar 5, 2024
| @@ -3,19 +3,58 @@ | |||
| require_relative 'book' | |||
| require_relative 'highlight' | |||
| require_relative 'tag' | |||
| require_relative 'document' | |||
There was a problem hiding this comment.
Warning
tODO: update the README with examples of these methods and a disclaimer that they are in beta and liable to change.
| @@ -1,3 +1,5 @@ | |||
| require 'readwise' | |||
There was a problem hiding this comment.
Warning
TODO: Write tests for the new methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this is clearly still in beta (liable to change) because there are cases where the docs don't match the data (e.g.
published_date).Addresses #1