-
Notifications
You must be signed in to change notification settings - Fork 2
Make sample config json valid #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@sycdan - I'm so sorry for the delay here! Thank you so much for your contribution! I'm right in the middle of getting another project out but I'll come back and review in the next couple of days. Thank you for making my day with a PR! |
If you could check the minor comments here and run the listing/formatting locally, I'm fine with merging: https://github.com/joshcanhelp/budget-cli/blob/main/CONTRIBUTING.md#i-want-to-make-code-changes Thanks again @sycdan! |
Awesome, will try to publish the cleanup soon! |
bonus: - Make sample config json valid - Fix minor issues in usage doc - Update name of example translator
@sycdan - Hey there ... just checking in on this. If you're not able to look at the spacing in the docs, I can give it a look. Thanks! |
Sorry, I thought I had fixed up what things you pointed out. What would you like me to do? Change tabs to spaces? |
docs/configuration.md
Outdated
@@ -4,80 +4,81 @@ This tool can be configured using a `.budget-cli.json` file in the root of this | |||
|
|||
```json | |||
{ | |||
"outputFile": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the spacing here went from spaces to tabs, making it hard to see any changes that might have been made.
@sycdan - Thanks again for this! |
Last night I happened to search for "cli budgeting tool", fully expecting Google to laugh in my face because why would such a thing exist, at which point I would have proceeded to write this exact tool only in Python. However! This was the first hit and I loved it instantly.
I have just started getting it set up, but my first order of business was to make a parser for my Amex statements, and I thought I'd share.
Bonus documentation changes:
amount
description--input
argument name