small edits #15
Open
small edits #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
made it clear what Chromatic is at the top of the readme, and edited the motivation description to remove redundancy.
joshdk
requested changes
Jul 21, 2018
| # Chromatic | ||
|
|
||
| 🍪 Configurable human assisted Chrome automation | ||
| 🍪 Chromatic is a tool for Configurable human assisted Chrome automation. |
There was a problem hiding this comment.
The capitalization needs to be fixed, and it doesn't read quite right. How about:
🍪 A tool for configurable, human-assisted Chrome automation
Having "Chromatic" at the start of the line and as the header above, stutters a little.
| There are certain services that require programmatic interaction, but otherwise make it difficult. Web-only APIs, [CAPTCHAs](https://en.wikipedia.org/wiki/CAPTCHA), and MFA are a few examples of things that might not work well with typical automation. | ||
|
|
||
| This tool, `chromatic`, implements an escape-hatch around these difficulties. It can be configured to open up a Chrome window to a given starting URL, and will continue to be interactive until a given set of ending conditions are met, at which time the Chrome window will close. This user interaction is typically a login flow. | ||
| `Chromatic` implements an escape-hatch around these difficulties. It can be configured to open up a Chrome window to a given starting URL, and will continue to be interactive until a given set of ending conditions are met, at which time the Chrome window will close. This user interaction is typically a login flow. |
There was a problem hiding this comment.
I like this. Small nitpick would be to just have the word "Chromatic" in non-code style. Use chromatic when referring to command line literals.
|
I would like to incorporate your changes @Norbgorb, any thoughts on the proposed revisions? Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
made it clear what Chromatic is at the top of the readme, and edited the motivation description to remove redundancy.