Update zooom function to support refactored chartSeries function#113
Open
erichung0404 wants to merge 1 commit intojoshuaulrich:masterfrom
Open
Update zooom function to support refactored chartSeries function#113erichung0404 wants to merge 1 commit intojoshuaulrich:masterfrom
erichung0404 wants to merge 1 commit intojoshuaulrich:masterfrom
Conversation
As S4 method used by chartSeries is deprecated, xdata and xsubset should be obtained from .plotxtsEnv environment. plot object is printed if users want to select period more than once (n>1).
erichung0404
changed the title
erichung0404
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since S4 method used by chartSeries is deprecated, xdata and xsubset should
now be obtained from
.plotxtsEnvenvironment.plot object needs to be returned by calling
return()or being executed at the endof the code otherwise it will not be printed. To print both the plot object and
"done" message,
print()is used. But passing the plot object created byzooom()to an object is not supported.