Add more ConditionVisitor cases (and fix minor bug) #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added are MLIL_CMP_SLT, MLIL_CMP_UGE, MLIL_CMP_ULT
Tuple was being used as basic block, led to no .start attribute error. Fixed by looking at index 0 instead, which seems to be the index that holds the bb.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for posting this code Josh!
I threw a couple random binaries I had laying around at it, and tweaked it until they would decompile.
MLIL_CMP_*operations to theConditionVisitor[0]got lost in a refactor, so it was failing on a type error in some cases, I think I've fixed it. No promises it didn't break elsewhere, but works on my machine!Your stream has been interesting the few times I've been able to watch, hopefully I'll have more time to watch in the future.