Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support: location.hash #30

Merged
merged 5 commits into from
Mar 10, 2024
Merged

support: location.hash #30

merged 5 commits into from
Mar 10, 2024

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Feb 19, 2024

otherwise, there's no way to clear hash.

Copy link

codesandbox-ci bot commented Feb 19, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@dai-shi dai-shi requested a review from Flirre March 10, 2024 13:20
Copy link
Collaborator

@Flirre Flirre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests passing ✅
Very logical addition to the atomWithLocation ✅

@dai-shi
Copy link
Member Author

dai-shi commented Mar 10, 2024

thanks. feel free to merge and publish a new version whenever you think is appropriate.

@Flirre Flirre merged commit cf8a8e4 into main Mar 10, 2024
3 checks passed
@Flirre Flirre deleted the support-location-hash branch March 10, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants