Skip to content

Conversation

@jpmcmu
Copy link
Owner

@jpmcmu jpmcmu commented Jul 23, 2024

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change is a breaking change (fix or feature that will cause existing behavior to change).

Checklist:

  • I have created a corresponding JIRA ticket for this submission
  • My code follows the code style of this project.
    • I have applied the Eclipse code-format template provided.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the HPCC Systems CONTRIBUTORS document (https://github.com/hpcc-systems/HPCC-Platform/wiki/Guide-for-contributors).
  • The change has been fully tested:
    • This change does not cause any existing JUnits to fail.
    • I have include JUnit coverage to test this change
    • I have performed system test and covered possible regressions and side effects.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Premature optimization
    • This change fixes the problem, not just the symptom

Testing:

jpmcmu added 2 commits July 23, 2024 14:38
- Added missing changes
- Updated transition flow logic

Signed-off-by: James McMullan James.McMullan@lexisnexis.com
@github-actions
Copy link

Jira Issue: https://hpccsystems.atlassian.net/browse/HPCC4J-608

Jirabot Action Result:
Assigning user: james.mcmullan@lexisnexisrisk.com
Workflow Transition To: Accepted
Error: Transitioning to: "Active" failed with: "'transition' identifier must be an integer" Valid transitions=[{'name': 'Reject', 'id': 141, 'to': 'Resolved'}, {'name': 'Assign as unresourced', 'id': 231, 'to': 'Unresourced'}, {'name': 'Merge Pending', 'id': 291, 'to': 'Merge Pending'}, {'name': 'Schedule', 'id': 171, 'to': 'Planned'}]
Workflow Transition To: Merge Pending
Additional PR: #36

@jpmcmu jpmcmu closed this Jul 23, 2024
@jpmcmu jpmcmu reopened this Jul 23, 2024
@github-actions
Copy link

Jira Issue: https://hpccsystems.atlassian.net/browse/HPCC4J-608

Jirabot Action Result:
Assigning user: james.mcmullan@lexisnexisrisk.com
Workflow Transition To: Merge Pending
Additional PR: #36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants