Increase timeout when using proxy #436
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On large playlists and/or high-latency networks there is not enough time for all album covers to download: > WARN psst_gui::delegate] failed to fetch image: https://i.scdn.co/image/... Connection Failed: tls connection init failed: Resource temporarily unavailable (os error 11)
|
Thanks for the PR! @Insprill do you think this would cause any side effects? I think it's within reason for long playlists. |
Insprill
requested changes
Sep 10, 2023
| @@ -5,9 +5,9 @@ use quick_protobuf::{BytesReader, MessageRead, MessageWrite, Writer}; | |||
|
|
|||
| use crate::error::Error; | |||
|
|
|||
| pub const NET_CONNECT_TIMEOUT: Duration = Duration::from_millis(8 * 1000); | |||
| pub const NET_CONNECT_TIMEOUT: Duration = Duration::from_millis(16 * 1000); | |||
There was a problem hiding this comment.
Does the connection timeout need to be increased?
|
Hello, thank you both! |
|
@Insprill I can remove the change from NET_CONNECT_TIMEOUT and we can merge? |
|
Yeah that'd be good, I'd like to get this merged too. |
Merged
|
See #442 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On large playlists and/or high-latency networks there is not enough time for all album covers to finish downloading.
Thank you 😃