Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for Universal Binary for MacOS on M1 #450

Merged
merged 8 commits into from
Jan 23, 2024
Merged

Adding support for Universal Binary for MacOS on M1 #450

Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
efc17c8
adding universal binary support
dscso Jan 22, 2024
1abcbdd
Update build.yml
dscso Jan 22, 2024
2587f61
seperate aarch64 build from bundling process
dscso Jan 22, 2024
b1377e7
seperate further
dscso Jan 22, 2024
40f82e6
Little hacky fix for cargo bundle not building both (aarch64 and x86)
dscso Jan 22, 2024
70cf99c
Changing name
dscso Jan 22, 2024
af55841
Change name
jacksongoode Jan 22, 2024
defe3da
Change README link
jacksongoode Jan 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,13 +49,23 @@ jobs:

- name: Build Release
run: cargo build --release


- name: Build aarch64 for MacOS
if: ${{ runner.os == 'macOS' }}
run: |
rustup target add aarch64-apple-darwin
cargo build --release --target aarch64-apple-darwin

- name: Bundle macOS Release
if: ${{ runner.os == 'macOS' }}
run: |
cargo install cargo-bundle
cargo bundle --release
working-directory: psst-gui

- name: replacing binary with universal binary
Insprill marked this conversation as resolved.
Show resolved Hide resolved
if: ${{ runner.os == 'macOS' }}
run: lipo target/release/psst-gui target/aarch64-apple-darwin/release/psst-gui -create -output target/release/bundle/osx/Psst.app/Contents/MacOS/psst-gui

- name: Create macOS Disk Image
if: ${{ runner.os == 'macOS' }}
Expand Down
Loading