Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix macOS universal build & support macOS >= 11 #484

Merged
merged 12 commits into from
Jul 1, 2024
Merged

Fix macOS universal build & support macOS >= 11 #484

merged 12 commits into from
Jul 1, 2024

Conversation

jacksongoode
Copy link
Collaborator

@jacksongoode jacksongoode commented Jun 26, 2024 •
edited
Loading

This fixes an issue with our universal builds, it also:

  • adds the MACOSX_DEPLOYMENT_TARGET so we can support older versions than what the macOS runner is set to
  • Lints a few depreciated usize imports
  • Bumps the version of the actions to use Node 20 so we don't get depreciation warnings

@jacksongoode jacksongoode marked this pull request as draft June 28, 2024 18:43
@jacksongoode jacksongoode marked this pull request as ready for review June 28, 2024 18:43
@jacksongoode
Copy link
Collaborator Author

@alejandrot96 I think this is good to go, but I will need someone to test and confirm this.

@jacksongoode jacksongoode changed the title Fix macOS universal build Fix macOS universal build & support macOS >= 11 Jul 1, 2024
@jacksongoode
Copy link
Collaborator Author

jacksongoode commented Jul 1, 2024 •
edited
Loading

I had someone on Intel running 11.6 confirm this works on their machine so I think this is good to merge.

@alejandrot96
Copy link

last one is working on ventura 👌🏽

@jacksongoode jacksongoode merged commit 16b06ab into master Jul 1, 2024
6 checks passed
@jacksongoode jacksongoode deleted the jackson/fix-mac-uni-build branch July 1, 2024 21:50
@jacksongoode jacksongoode mentioned this pull request Jul 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Insprill Insprill Awaiting requested review from Insprill

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacksongoode @alejandrot96