Save config on exit, not interaction #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested this on Linux and Windows and it seems to work fine! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the behavior of how we save the config to save only when Psst is completely closed. This reduces the unnecessary need to save the config anytime the state changes.
Ideally, we should be able to capture all instances of an application closing, except in the most extreme case, so that we can restore the state from its last configuration.
There appears to be a workaround for macOS to handle the Cmd+Q hotkey given that it doesn't seem at least on macOS that you can capture the QUIT_APP command. This will need to be tested on Windows and Linux.