-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI cleanup for save track icon #498
Conversation
7aa16ad
to
c63c452
Compare
Isn't this the same issue as #457 so not newly introduced? |
Yeah actually I made that issue thinking it was the same behavior with the standard UI but the regular UI doesn't put the saved icon on top of the clickable track widget - it adds it to the side. Currently there are two issues with this PR:
|
c63c452
to
b3830e9
Compare
Just a thought but in the ui clean-up branch we could also include some extra icons for visulizing some keyboard bindings, also we should say what they are in the settings to make people aware to how to use them. For example for the search in playlist I think we could have a little icon. We could also have a temporary refresh button introduced. This would also help with #206 |
I like that idea, I've tried my best to figure out how overlapping triggers in druid can be prevented but I have no idea. I think this can be a PR replacing the heart with the plus. What do you think? |
Yeah that sounds good!! I like the fact that the save button will stay larger. |
This PR:
Here's what it would look like:
However, this introduces an issue where clicking on the save icon actually triggers the parents play action - so that would need to be fixed.