Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make volume slider one line #504

Merged
merged 4 commits into from
Jul 29, 2024
Merged

Make volume slider one line #504

merged 4 commits into from
Jul 29, 2024

Conversation

jacksongoode
Copy link
Collaborator

@jacksongoode jacksongoode commented Jul 26, 2024

It never made any sense to me why the volume controls were on two separate lines. It only contributed to the height of that very minimal controls panel. I think this makes a lot more sense and we don't need the volume title given that this is intuitive.

image

@jacksongoode
Copy link
Collaborator Author

image

I was messing a bit with padding and actually this makes me feel even cozier? Thoughts?

@jacksongoode
Copy link
Collaborator Author

@SO9010 Since this might affect your queue panel branch, it would be great if you had a look. I think reducing the two line volume to one will make reducing the height of that panel feel less cramped.

@SO9010
Copy link
Contributor

SO9010 commented Jul 26, 2024

Just tested! It works well in my queue panel branch! However, since it now has a slight highlighting, it would make more sense to have it so that when you click on your name, it brings up the user profile page.

Or we could have the whole thing as the settings button, as that makes more sense; at least, to me, it does!

The connected writing is also crucial, in my opinion.

@jacksongoode
Copy link
Collaborator Author

Or we could have the whole thing as the settings button

Right, I thought of that, I think its a bit weird that it's such a huge button with a lot of space in between at wide windows. I'm not so sure.

@jacksongoode
Copy link
Collaborator Author

@SO9010 Just going to go with the prior way the naming and settings looked with a little less padding and a bit of space between the "Connected" and the username (before it was a little oddly smushed I felt) and we have more height to spare.

I also lowered the height of the that pref box to 88 so it's even like in your PR.

@jacksongoode jacksongoode merged commit d895cb9 into master Jul 29, 2024
5 checks passed
@jacksongoode jacksongoode deleted the jackson/volume-one-line branch July 29, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants