Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New authentication flow to resolve #515 #517

Merged
merged 6 commits into from
Sep 3, 2024

Conversation

jacksongoode
Copy link
Collaborator

@jacksongoode jacksongoode commented Aug 24, 2024

This resolves the issue with a new OAuth method largely referencing the work done in librespot librespot-org/librespot#1309. After this username/pass is completely depreciated. I may not have removed all unused references so I'd be happy for reviews and edits.

@jacksongoode
Copy link
Collaborator Author

@Insprill Since this is a big one and high prio, would you have time to look over this and review?

@jacksongoode
Copy link
Collaborator Author

@SO9010 Just to check with another person, does this method work for you from this branch?

@kingosticks
Copy link

kingosticks commented Aug 27, 2024

By the way, now everyone required is back from holiday we'll hopefully be merging our librespot PR for this. It's currently going through some review. The intention is to publish a librespot-oauth create but when that'll see an actual release, I can't say. I appreciate you might prefer to control your own copy of that code, this is more just a note that the original version is seeing some updates (error handling mostly) so there may be value in waiting for those.

@SO9010
Copy link
Contributor

SO9010 commented Aug 27, 2024

@SO9010 Just to check with another person, does this method work for you from this branch?

I'll try it out tomorrow!

@jacksongoode
Copy link
Collaborator Author

By the way, now everyone required is back from holiday we'll hopefully be merging our librespot PR for this. It's currently going through some review. The intention is to publish a librespot-oauth create but when that'll see an actual release, I can't say. I appreciate you might prefer to control your own copy of that code, this is more just a note that the original version is seeing some updates (error handling mostly) so there may be value in waiting for those.

@kingosticks Thanks for the update, I've been following changes to that PR. I think it does just make sense to roll our own implementation here. If you notice anything odd here feel free to point it out, it was based around your work so thank you!

@SO9010
Copy link
Contributor

SO9010 commented Aug 28, 2024

@jacksongoode This works perfectly for me!!!

@jacksongoode jacksongoode merged commit 0cd9904 into master Sep 3, 2024
5 checks passed
@jacksongoode jacksongoode deleted the jackson/new-auth-method branch September 3, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants