Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show empty on error for home #531

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

SO9010
Copy link
Contributor

@SO9010 SO9010 commented Sep 25, 2024

Proposal partial fix for the inconsistent display of widgets from Spotify recommended endpoints. This could be an issue (guessing here) as they are changed constantly and perhaps aren't always available as endpoints?

Copy link
Collaborator

@jacksongoode jacksongoode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, it would be nice if there was some way to add an error is the whole group is empty, but given that these endpoints are flaky, I think this is a better alternative than now.

@SO9010
Copy link
Contributor Author

SO9010 commented Sep 25, 2024

Just need to make it so that uniquely yours doesn't show if there's an error then it can be merged!

@SO9010
Copy link
Contributor Author

SO9010 commented Sep 25, 2024

@jacksongoode this should be good now!

@jacksongoode jacksongoode merged commit ecc0115 into jpochyla:master Sep 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants