Changes ISOServer channels map implementation to ConcurrentHashMap #539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #508 by using a ConcurrentHashMap. Also refactored dump a bit. Functionally it is exactly the same.
About the issue ConcurrentHashMap has weak consistency guarantees but will handle mid iteration insertions transparently. Could still potentially dump inconsistent data if an insertion happens mid iteration as in there's no guarantee the iterator is actually updated with new entries but it's a tradeoff.
The alternative would be to lock any access to the map but seems overkill for a SystemMonitor dump and would probably perform worse as we would have to lock on get() which ConcurrentHashMap tries to avoid. Collections.synchronizedMap() does not solve this issue either.
On another note, to be honest I couldn't find where exactly someone might put a channel mid iteration. ISOServer seems to only support a single channel at a time.