Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI action to build WASM #23

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Add CI action to build WASM #23

merged 2 commits into from
Oct 26, 2023

Conversation

thegecko
Copy link
Contributor

This PR should add a GitHub action which builds the llvm WASM file (about 2 hours).

If triggered using a tag, a package should also be published onto the GitHub npm registry with emscripten types to allow the WASM file to be imported by another project e.g.:

import LlvmBoxModule from '@jprendes/emception';
...
async #init(LlvmBoxModule, FS, opts) {
...

This was developed to separate our usage of llvm-box from a consuming project. Feel free to use it as inspiration if something else is required in this project

@jprendes
Copy link
Owner

Thanks for the PR!
This is not using npmjs.com's registry but rather github's npm registry, right?

@jprendes
Copy link
Owner

I think the CI problem is with -it in docker run.
Changing it to -i should fix the failure.

@thegecko
Copy link
Contributor Author

This is not using npmjs.com's registry but rather github's npm registry, right?

that's right

I think the CI problem is with -it in docker run.
Changing it to -i should fix the failure.

thanks, forgot to change that

@jprendes
Copy link
Owner

LGTM

@jprendes jprendes merged commit 205e46a into jprendes:master Oct 26, 2023
2 checks passed
@thegecko
Copy link
Contributor Author

Although the action succeeded, it failed to find the output files, does this look right?

        ./build/llvm/bin/llvm-box.wasm
        ./build/llvm/bin/llvm-box.mjs

@jprendes
Copy link
Owner

Nop, that doesn't look correct.
Do you have bandwidth to take a look?

@thegecko
Copy link
Contributor Author

Ok, could you tell me where the output llvm wasm and mjs files end up? I don't have a set up I can look at

@jprendes
Copy link
Owner

hm, I just checked, and the two files should be there: ./build/llvm/bin/llvm-box.{wasm,mjs}

@thegecko
Copy link
Contributor Author

OK, I'll build locally and see whats going on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants