Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Name Change to save old player Names #31

Merged
merged 4 commits into from
Jan 30, 2025
Merged

Conversation

jprzimba
Copy link
Owner

@jprzimba jprzimba commented Jan 30, 2025

Description

This feature implements a name change system that saves old player names in a new database table, player_oldnames.

Behaviour

Actual

Dont save player old names

Expected

Save old player names to database

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested

Tested with store name changer

Test Configuration:

  • Server Version: 4.1.3
  • Client: 14.05
  • Operating System: Windows

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@jprzimba jprzimba added the enhancement New feature or request label Jan 30, 2025
@jprzimba jprzimba merged commit 7c4017a into main Jan 30, 2025
24 of 28 checks passed
@jprzimba jprzimba deleted the name-changer branch January 30, 2025 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant