Skip to content

Commit

Permalink
Issue travis-ci#1190 - Adding Quotes for Orgs & Spaces
Browse files Browse the repository at this point in the history
Organization and Space names can have spaces in them which will break the login and target commands.
Rather than expecting the user to discover this and fix in their .travis.yml files, it's easy enough to just add the `"` in here.
  • Loading branch information
jpwsutton authored May 1, 2020
1 parent d0ced42 commit 1602f97
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions lib/dpl/providers/bluemixcloudfoundry.rb
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ class Bluemixcloudfoundry < Provider

cmds install: 'test $(uname) = "Linux" && rel="linux64-binary" || rel="macosx64"; wget "https://cli.run.pivotal.io/stable?release=${rel}&source=github" -qO cf.tgz && tar -zxvf cf.tgz && rm cf.tgz',
api: './cf api %{api} %{skip_ssl_validation_opt}',
login: './cf login -u %{username} -p %{password} -o %{organization} -s %{space}',
target: './cf target -o %{organization} -s %{space}',
login: './cf login -u %{username} -p %{password} -o "%{organization}" -s "%{space}"',
target: './cf target -o "%{organization}" -s "%{space}"',
push: './cf push %{push_args}',
logout: './cf logout'

Expand Down

0 comments on commit 1602f97

Please sign in to comment.