Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-bugfix about zero & wide definition conflicts (again!) #110

Merged
merged 5 commits into from
Jan 6, 2024

Conversation

jquast
Copy link
Owner

@jquast jquast commented Jan 3, 2024

In this update to update-tables.py, 04d6d90 I wrote,

verify-table-integrity.py exercises a "bug" of duplicated tables that has no effect, because wcswidth() first checks for zero-width, and that is preferred in cases of conflict. This PR also resolves that error of duplication.

In that change I used method set.discard() in error, the discard method takes a single item as an argument, while I was providing using a whole set and so it had no effect. Instead, I now use set.difference() to re-assign the set value.

Also,

  • the category_codes argument has been removed in update-tables.py, it is not used.
  • verify-table-integrity.py has been improved to show both range values in conflict
  • verify-table-integrity.py now included as a unit test for a single version of python (3.12)
  • new unit test about conflicting wide & zero values. This demonstrates that the update to table_wide.py has no effect, as these tests succeed before and after change to table_wide.py.

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0ba0278) 100.00% compared to head (594fc27) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #110   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          105       105           
  Branches        25        25           
=========================================
  Hits           105       105           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jquast jquast merged commit 3af992a into master Jan 6, 2024
42 checks passed
@jquast jquast deleted the jq/non-bugfix-round2 branch January 6, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant