Skip to content

Conversation

@hugovk
Copy link
Contributor

@hugovk hugovk commented Nov 21, 2025

Fixes #151.

Replaces the deprecated license classifiers with PEP 639 metadata: https://hugovk.dev/blog/2025/improving-licence-metadata/

@hugovk
Copy link
Contributor Author

hugovk commented Nov 21, 2025

TypeError: Field `project.license-files` must be a table

The new metadata isn't supported for 3.6 and 3.7: https://github.com/hugovk/wcwidth/actions/runs/19575036750/job/56057960860

Let's drop them, they've been EOL since 2021-12-23 and 2023-06-27:

https://devguide.python.org/versions/

@GalaxySnail
Copy link
Collaborator

By thw way, since setuptools >= 61 supports PEP 621, I think we can use pyproject.toml + setuptools.


def read_sequences_from_file(filename):
fp = open(os.path.join(os.path.dirname(__file__), filename), 'r', encoding='utf-8')
fp = open(os.path.join(os.path.dirname(__file__), filename), encoding='utf-8')

Check warning

Code scanning / CodeQL

File is not always closed Warning test

File may not be closed if
this operation
raises an exception.
@hugovk
Copy link
Contributor Author

hugovk commented Nov 21, 2025

Any particular reason to stick with setuptools instead of something more modern?

@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (a753ba4) to head (e927f5d).
⚠️ Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #156   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          100       100           
  Branches        20        20           
=========================================
  Hits           100       100           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@GalaxySnail
Copy link
Collaborator

One reason is that we can keep the setup.py in this version, which generates a warning for those who are still calling python setup.py. And since setuptools works well with modern specifications, there's no need to replace it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

setup.py deprecation -- pyproject.toml, license, codecs

2 participants