Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable GitHub Actions CI #76

Merged
merged 5 commits into from
Sep 23, 2023
Merged

Enable GitHub Actions CI #76

merged 5 commits into from
Sep 23, 2023

Conversation

GalaxySnail
Copy link
Collaborator

@GalaxySnail GalaxySnail commented Sep 14, 2023 •
edited
Loading

replace and close #75

GalaxySnail and others added 5 commits September 14, 2023 18:31
@GalaxySnail
Enable GitHub Actions CI
5188204 
Drop python 2.6 and python 3.4 because our test dependencies don't
support them.

ref: https://github.com/python-attrs/attrs/blob/06b1bb414121bd21dd0781016a035ed1388aa136/.github/workflows/ci.yml
@GalaxySnail
Fix coverage combine failure
8e310a7 
ref: https://coverage.readthedocs.io/en/latest/config.html#run-relative-files
@GalaxySnail
Improve coverage
f4cd505 
ignore unreachable code and replace a list-comprehension with map
@GalaxySnail
Test on pypy
cd2e1af
@GalaxySnail @trim21
Upload coverage to Codecov
03ea8b7 
Co-authored-by: Trim21 <trim21.me@gmail.com>
@GalaxySnail GalaxySnail mentioned this pull request Sep 14, 2023
Closed
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed Coverage
wcwidth/table_wide.py ø
wcwidth/table_zero.py ø
wcwidth/unicode_versions.py ø
wcwidth/wcwidth.py 100.00%

📢 Thoughts on this report? Let us know!.

jquast
jquast approved these changes Sep 23, 2023
View reviewed changes
Copy link
Owner

@jquast jquast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great work, all the way back to python 2.7 and nice coverage fix, thank you.

@jquast jquast merged commit 552040b into jquast:master Sep 23, 2023
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jquast jquast jquast approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GalaxySnail @jquast