Add camlp5 8.03 support, update make switch to use it #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds camlp5 8.03 support and does the following updates: - Update `make switch` to use it - Move all `pa_j_*` files into a new directory `pa_j`, and add `README` that informally describes how these files are created. - Update the label of Github CI from camlp5 8.02 to camlp5 8.03 . Using camlp5 8.03 is necessary to enable using native OCaml REPL in the future.
|
I checked that s2n bignum proofs checked successfully with this patch. |
|
Thank you, this is a very worthwhile reorganization and improvement. I've checked that the new "make switch" combination works on several platforms, and that direct build still works equally well the the "native" OCaml and camlp5 versions on those platforms (ranging from OCaml 4.05 to 5.1). |
|
Thanks. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds camlp5 8.03 support and does the following updates:
make switchto use itpa_j_*files into a new directorypa_j, and addREADMEthat informally describes how these files are created.Using camlp5 8.03 is necessary to enable using native OCaml REPL in the future.