Fix tactics in impconv.ml to raise Failure rather than Unchanged #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tactics in impconv.ml may raise `Unchanged` rather than `Failure` if they fail. This makes `ORELSE` unable to use because `ORELSE` only catches `Failure` but not `Unchanged`: ``` # g `1 + 1 = 2`;; val it : goalstack = 1 subgoal (1 total) `1 + 1 = 2` # e(IMP_REWRITE_TAC[MOD_LT] ORELSE ARITH_TAC);; Exception: Unchanged. ``` This patch fixes the tactics to raise `Failure` to enable this.
|
Passed s2n-bignum and holtest |
jrh13
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tactics in impconv.ml may raise
Unchangedrather thanFailureif they fail. This makesORELSEunable to use becauseORELSEonly catchesFailurebut notUnchanged:This patch fixes the tactics to raise
Failureto enable this.