This repository has been archived by the owner on Nov 1, 2019. It is now read-only.
Custom order validator #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged. Thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Implementing a Custom Order Validator"
I used one less image in this one because the validator itself is a little abstract, and really the evidence of it being there in the UI is just the error message. Also, I noticed that, because of the somewhat longer lists of parameters for the method names in the walkthrough section, the lines showing the method signatures introducing them look a little uglier (e.g., 25abf77#diff-ea06c23efbf3a7f1464e6a4dfd92cfacR133). I am not sure if there's a better way to do it or if that's just going to be necessary though.
Let me know what you think when you can though. Thanks.