Fix maintenance day of week (linode#374)

For the DBaaS maintenance window, Our API considers: 1=Monday, 2=Tuesday, ... But our existing `linodego` code considers: 1=Sunday, 2=Monday ... This PR makes `linodego` align with the API design.
jriddle-linode · Sep 5, 2023 · 1df9dbe · 1df9dbe
1 parent cc1e919
commit 1df9dbe
Show file tree

Hide file tree

Showing 7 changed files with 6,267 additions and 9,199 deletions.
diff --git a/databases.go b/databases.go
@@ -19,13 +19,13 @@ type (
 )
 
 const (
-	DatabaseMaintenanceDaySunday DatabaseDayOfWeek = iota + 1
-	DatabaseMaintenanceDayMonday
+	DatabaseMaintenanceDayMonday DatabaseDayOfWeek = iota + 1
 	DatabaseMaintenanceDayTuesday
 	DatabaseMaintenanceDayWednesday
 	DatabaseMaintenanceDayThursday
 	DatabaseMaintenanceDayFriday
 	DatabaseMaintenanceDaySaturday
+	DatabaseMaintenanceDaySunday
 )
 
 const (

diff --git a/test/integration/fixtures/TestDatabase_List.yaml b/test/integration/fixtures/TestDatabase_List.yaml
diff --git a/test/integration/fixtures/TestDatabase_MySQL_Suite.yaml b/test/integration/fixtures/TestDatabase_MySQL_Suite.yaml
diff --git a/test/integration/fixtures/TestDatabase_Postgres_Suite.yaml b/test/integration/fixtures/TestDatabase_Postgres_Suite.yaml
diff --git a/test/integration/integration_suite_test.go b/test/integration/integration_suite_test.go
@@ -27,8 +27,8 @@ var (
 )
 
 var (
-	testingPollDuration = time.Duration(15000)
-	testingMaxRetryTime = time.Duration(30) * time.Second
+	testingPollDuration = 15 * time.Second
+	testingMaxRetryTime = 30 * time.Second
 )
 
 func init() {

diff --git a/test/integration/mysql_test.go b/test/integration/mysql_test.go
@@ -182,7 +182,7 @@ func createMySQLDatabase(t *testing.T, client *linodego.Client,
 		Label:           "go-mysql-test-def",
 		Region:          getRegionsWithCaps(t, client, []string{"Managed Databases"})[0],
 		Type:            "g6-nanode-1",
-		Engine:          "mysql/8.0.26",
+		Engine:          "mysql/8.0.30",
 		Encrypted:       false,
 		ClusterSize:     3,
 		ReplicationType: "semi_synch",
@@ -204,7 +204,7 @@ func createMySQLDatabase(t *testing.T, client *linodego.Client,
 		ctx, cancel := context.WithTimeout(context.Background(), 180*time.Second)
 		defer cancel()
 
-		ticker := time.NewTicker(client.GetPollDelay() * time.Millisecond)
+		ticker := time.NewTicker(client.GetPollDelay())
 		defer ticker.Stop()
 
 		for {

diff --git a/test/integration/postgres_test.go b/test/integration/postgres_test.go
@@ -182,7 +182,7 @@ func createPostgresDatabase(t *testing.T, client *linodego.Client,
 		Label:           "go-postgres-testing-def",
 		Region:          getRegionsWithCaps(t, client, []string{"Managed Databases"})[0],
 		Type:            "g6-nanode-1",
-		Engine:          "postgresql/10.14",
+		Engine:          "postgresql/14.6",
 		Encrypted:       false,
 		SSLConnection:   false,
 		ClusterSize:     3,
@@ -203,7 +203,7 @@ func createPostgresDatabase(t *testing.T, client *linodego.Client,
 		ctx, cancel := context.WithTimeout(context.Background(), 180*time.Second)
 		defer cancel()
 
-		ticker := time.NewTicker(client.GetPollDelay() * time.Millisecond)
+		ticker := time.NewTicker(client.GetPollDelay())
 		defer ticker.Stop()
 
 		for {