Include logger silence from active support #270
Conversation
|
Hi @jlahtinen - slightly unrelated to this, but which rack version are you using jruby-rack with? |
rack (2.2.9) |
|
Interesting. Do you use with rails? (Probably a.dumb question given you are trying to make it work better with Puma here - so probably 'no' which would explain why you don't have some of the same issues I see, and the rails appraisal tests have) |
|
@chadlwilson sorry I did not understand puma reasoning :). Most of the developer time goes running rails app with puma. We are using rails (6.1.7.7) currently In production there is tomcat 9 and jryby-rack in action |
|
OK my bad, I don't know Puma - I thought it might include a framework alternative to Rails, and was confused about your earlier references to using Tomcat as webserver if there is also Puma in the mix. But that's probably similar to my setup in a sense (Rails 6.1). |
| class RailsLogger < JRuby::Rack::Logger | ||
| include ActiveSupport::LoggerSilence | ||
|
|
||
| def info(*args) |
There was a problem hiding this comment.
why is the info level overriden here?
There was a problem hiding this comment.
I can't remember anymore. And now it looks like it should not override it.
Unfortunately I do not have time to test this right now. Maybe later today or tomorrow
|
PR still needs work to make tests pass as well. Id also feel more comfortable if we get #271 in first which tests more with rails by enabling the old rails appraisals and will avoid unintentionally making certain breaking changes for certain rails versions. |
|
I also think this is not ready to be merged. But I hope we can discuss how silence should be implemented. I was also thinking that should jruby-rack allow rails to initialize rails default logger somehow when no logger is specified. If I have understood correctly, jruby-rack now sets some jruby-rack specific default logger as rails logger if no other is set. Could this jruby-rack spesific default logger not be the default and let rails set the default like it does when running in e.g. puma? Does this make any sense? |
|
Yeah, the project I inherited has some kind of silence related hack as well as a custom slf4j logger. Been meaning to dig into that during the 1.2.x upgrade (since there are.logging changes there too). Currently still stuck on both jruby-rack 1.1 and rails 6.1 due to needing some fixes from here first. But we're close 👍 |
Suggested way to make logger work more like rails logged does in puma.