Replace deprecated rspec usage with modern expect usage

[chadlwilson]

Some minor reformatting required to make the automated replacements easier.

[kares]

just curious, what did you use to automate the replacements?

[chadlwilson]

Good question.

Believe it or not, I threw JetBrains Junie at it which got me 85% of the way there (just with default Claude Sonnet 3.7 underneath) with a bit of coaxing, and then getting annoyed at it breaking some syntax and screwing up some formatting, and not being able to run the tests itself due to PATH problems with jruby/java etc. Didn't try Sonnet 4 though. It mainly seemed to construct some dodgy error-prone regexes and then go back and fix syntax after I told it to, so maybe not so different to how I'd have done it, haha.

First time I have used Junie though, I am figuring my way through agent-mode for OSS refactoring, so wanting something easyish like this to have a go with.

Currently I have a Jetbrains Ultimate license and GH Copilot license for OSS usage, but not Jetbrains AI though, so will run out of credits pretty quickly :-)

[kares]

Nice, thought you had some kind of an AI approach.

I am also trying to figure out the best setup to help me around OSS (and beyond).
Thanks for sharing...

[chadlwilson]

Yeah, I already use GitHub Copilot quite a bit IDE-integrated for auto-completion, back-writing tests and just asking questions of (useful when working in language ecosystems I don't know well) but supervised refactoring like this should be relatively easy stuff for most of these models one would hope.