решение задач 2 модуля #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Добавляю преподавателя (@ufocoder) для код-ревью. |
|
Проверьте, пожалуйста, ваше решение, не все тесты прошли (PR не будет принят до тех пор, пока все добавленные задачи не будут решены). |
|
А, вот как работает синхронизация) |
ufocoder
reviewed
Jan 26, 2025
| @@ -5,5 +5,9 @@ | |||
| * @returns {object} - returns the new object | |||
| */ | |||
| export const pick = (obj, ...fields) => { | |||
| const result = {}; | |||
|
|
|||
| fields.map((item) => result[item] = obj[item]); | |||
There was a problem hiding this comment.
Не используйте map, используйте forEach или другой способ обхода массива
ufocoder
reviewed
Jan 26, 2025
| @@ -5,5 +5,9 @@ | |||
| * @returns {object} - returns the new object | |||
| */ | |||
| export const omit = (obj, ...fields) => { | |||
| const newObj = obj; | |||
|
|
|||
| fields.map((item) => delete newObj[item]); | |||
There was a problem hiding this comment.
Не используйте map, используйте forEach или другой способ обхода массива
|
Добавляю преподавателя (@ufocoder) для код-ревью. |
ufocoder
approved these changes
Jan 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Разработаны:
сортировка с учетом регистра и алфавита (sortStrings)
функция получения отсортированного объекта по перечисленным ключам (pick)
функция получения отсортированного объекта по не вошедшим в перечисление ключам (omit)
вышло как-то топорно, но не смогла придумать ничего другого (createGetter)