Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add OPTIONS as an allowed HTTP Method #591

Merged
merged 3 commits into from
Dec 17, 2024
Merged

feat: add OPTIONS as an allowed HTTP Method #591

merged 3 commits into from
Dec 17, 2024

Conversation

alexey-yarmosh
Copy link
Member

Fixes jsdelivr/globalping-probe#261

E2E should pass after the merge of jsdelivr/globalping-probe#265

@MartinKolarik
Copy link
Member 

  1) http measurement
       should finish successfully in case of OPTIONS request:
     TypeError: Cannot read properties of null (reading 'length')
      at Context.<anonymous> (test/e2e/cases/http.test.ts:54:50)
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

@MartinKolarik MartinKolarik merged commit fc926b7 into master Dec 17, 2024
5 checks passed
@MartinKolarik MartinKolarik deleted the options-http branch December 17, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinKolarik MartinKolarik MartinKolarik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add OPTIONS as an allowed HTTP Method
2 participants
@alexey-yarmosh @MartinKolarik