Improve the regularization term #288
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, sorry to bother you. Now I have fixed the regular item vulnerability to ensure that its function is consistent with the original business logic. Thank you for your reminder. |
domenic
added a commit
that referenced
this pull request
Feb 9, 2025
Due to a V8 bug (https://issues.chromium.org/issues/42204424), negative end-of-string matches are slow, as shown in #286. We can avoid triggering this slowdown for certain inputs by just implementing the trimming using loops. Closes #286. Closes #288 by superseding it.
|
Thanks for identifying this issue. As shown in #289, I decided to go with a different solution, instead of the complicated regexp with negative lookahead. It appears to be faster than the regexp based on the benchmarks I added as well. |
|
Thank you for your reply, I think you are right, we do need to keep the code clean to ensure its readability. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To resolve this #286 issue, it is recommended to replace the original code containing the inefficient regular expression with the following optimized version:
This alternative simplifies the regular expression by removing the redundant | (OR) operator, effectively resolving the inefficient backtracking behavior. This optimization prevents potential performance degradation when handling specific inputs, ensuring more efficient processing.