Avoid using APIs deprecated in OpenSSL 3.0 #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good stuff. I will take a look at this PR this week. Preliminary review
looks good. Thanks!
…On Sun, Nov 27, 2022 at 8:19 PM Cameron Gutman ***@***.***> wrote:
This PR fixes OpenSSL 3.0 API deprecation warnings (or errors, if OpenSSL
3.0 was compiled without deprecated APIs). Most of the API changes were
trivial 1:1 replacements, but the EVP MAC API is a little more complex than
the old HMAC API was.
In this change, I also reordered the __APPLE__ checks to avoid creating a
mess of nested #ifs.
Verified teststuncode is passing with both OpenSSL 3.0 and OpenSSL 1.1.1.
------------------------------
You can view, comment on, or merge this pull request online at:
#48
Commit Summary
- 2bff5eb
<2bff5eb>
Avoid using APIs deprecated in OpenSSL 3.0
File Changes
(2 files <https://github.com/jselbie/stunserver/pull/48/files>)
- *M* stuncore/stunbuilder.cpp
<https://github.com/jselbie/stunserver/pull/48/files#diff-7d39a463a23a501bfb7cf606db310d3080934455a2418ec3f77d124b60426c68>
(9)
- *M* stuncore/stunreader.cpp
<https://github.com/jselbie/stunserver/pull/48/files#diff-d11ee9759ada5710e0b44ac4d60e4dcd28f115c5e4e9c6e6e674843d7e04965c>
(79)
Patch Links:
- https://github.com/jselbie/stunserver/pull/48.patch
- https://github.com/jselbie/stunserver/pull/48.diff
—
Reply to this email directly, view it on GitHub
<#48>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHNSF3FR7H3GROMSPM45ODWKQXGLANCNFSM6AAAAAASM4XNLQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Repository owner
deleted a comment from
Neustradamus
Aug 17, 2023
|
Is this PR ready for merging? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes OpenSSL 3.0 API deprecation warnings (or errors, if OpenSSL 3.0 was compiled without deprecated APIs). Most of the API changes were trivial 1:1 replacements, but the EVP MAC API is a little more complex than the old HMAC API was.
In this change, I also reordered the
__APPLE__checks to avoid creating a mess of nested#ifs.Verified
teststuncodeis passing with both OpenSSL 3.0 and OpenSSL 1.1.1.