[data source] Kickstarting section #19
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeorgLink
reviewed
Dec 20, 2019
Comment on lines
20
to
23
| The example below summarizes the projects.json structure. As can be seen, `GrimoireLab` and `Excalibur` are the | ||
| projects, which include `git` and `github` as data sources. The data sources of GrimoireLab are marked as `Stable`, while | ||
| the ones of Excalibur are set as `Alpha`. Finally, the repo `https:/github.com/Bitergia/citadel` includes the param | ||
| `--filter-no-collection=true` which prevents the collection of its data. |
There was a problem hiding this comment.
I would like clarification on the "meta" information:
Does "meta" tag data sources or does "meta" specify information about the project?
It looks to me like each project only has one "meta" that will apply to all data sources in that project, thus it seems more appropriate that the meta is describing the project.
Is that so, then we should clarify the language in lines 20-23.
There was a problem hiding this comment.
I pushed some new changes, but my feeling is that some work is still missing.
Signed-off-by: Valerio Cosentino <valcos@bitergia.com>
valeriocos
force-pushed
the
ds-management
branch
from
363f854 to
9495efb
Compare
|
@GeorgLink is there any blocker to not merge this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #5. The section
Editing projects, data sources & repositoriesis still TBD.