refactor(ui): move picker sources from Layer 0 to Layer 2#1391
Merged
breznknecht merged 1 commit intomainfrom Apr 1, 2026
Merged
refactor(ui): move picker sources from Layer 0 to Layer 2#1391breznknecht merged 1 commit intomainfrom
breznknecht merged 1 commit intomainfrom
Conversation
Four PickerSource modules in lib/minga/ aliased MingaEditor.UI.Picker.Item, violating the Layer 0 to Layer 2 dependency rule. These modules are presentation-layer (they implement Picker.Source and construct Picker.Item structs), so they belong in MingaEditor.*. Moved: - Minga.Diagnostics.PickerSource -> MingaEditor.UI.Picker.Sources.Diagnostics - Minga.Tool.PickerSource -> MingaEditor.UI.Picker.Sources.Tool - Minga.Tool.UninstallPickerSource -> MingaEditor.UI.Picker.Sources.ToolUninstall - Minga.Tool.UpdatePickerSource -> MingaEditor.UI.Picker.Sources.ToolUpdate Removed stale entries from credo exemption list. Zero upward deps remain from lib/minga/ or lib/minga_agent/ into MingaEditor.*.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
4 PickerSource modules in
lib/minga/aliasedMingaEditor.UI.Picker.Item, violating Layer 0 → Layer 2 dependency rules. Moved them toMingaEditor.UI.Picker.Sources.*where they belong, and cleaned up the credo exemption list.This closes the last upward dependency gap from the Wave 6 gate: