Do not add ampersand at end of URL with no params

jsmestad · May 15, 2024 · 2b13f92 · 2b13f92
1 parent 1a544fb
commit 2b13f92
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/lib/ueberauth/strategy/slack_v2/oauth.ex b/lib/ueberauth/strategy/slack_v2/oauth.ex
@@ -93,10 +93,10 @@ defmodule Ueberauth.Strategy.SlackV2.OAuth do
       |> endpoint(client)
 
     final_endpoint =
-      if params do
-        client_endpoint <> "?" <> URI.encode_query(params)
-      else
+      if Enum.empty?(params) do
         client_endpoint
+      else
+        client_endpoint <> "?" <> URI.encode_query(params)
       end
 
     final_endpoint

diff --git a/test/support/fixtures/custom_cassettes/slack-v2-responses.json b/test/support/fixtures/custom_cassettes/slack-v2-responses.json
@@ -34,7 +34,7 @@
 },
 {
 "request": {
-"url": "https://slack.com/api/auth.test?&"
+"url": "https://slack.com/api/auth.test?"
 },
 "response": {
 "status_code": 200,