Fix #148 by running fetchPrettyColumns before postProcess

jsoma · Sep 7, 2017 · 7314b99 · 7314b99
1 parent 624afd9
commit 7314b99
Show file tree

Hide file tree

Showing 4 changed files with 61 additions and 8 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "tabletop",
-  "version": "1.5.2",
+  "version": "1.5.3",
   "description": "**Tabletop.js** takes a Google Spreadsheet and makes it easily accessible through JavaScript. With zero dependencies!",
   "main": "src/tabletop.js",
   "directories": {

diff --git a/src/tabletop.js b/src/tabletop.js
@@ -455,7 +455,7 @@
       options.tabletop.log('Missing data for ' + this.name + ', make sure you didn\'t forget column headers');
       this.originalColumns = [];
       this.elements = [];
-      this.onReady.call(this);
+      this.ready();
       return;
     }
 
@@ -487,17 +487,13 @@
         element.rowNumber = i + 1;
       }
 
-      if (options.postProcess) {
-        options.postProcess(element);
-      }
-
       this.elements.push(element);
     }
 
     if (options.prettyColumnNames) {
       this.fetchPrettyColumns();
     } else {
-      this.onReady.call(this);
+      this.ready();
     }
   };
 
@@ -521,7 +517,16 @@
       });
     },
 
+    beforeReady: function() {
+      if(this.postProcess) {
+        for (i = 0, ilen = this.elements.length; i < ilen; i++) {
+          this.postProcess(element);
+        }
+      }
+    },
+
     ready: function() {
+      this.beforeReady();
       this.onReady.call(this);
     },