Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing any keyword instances with relevant data types #1040

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions components/Code.tsx
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import React, { useContext } from 'react';
import React, { useContext, ReactNode } from 'react';
import classnames from 'classnames';
import { BlockContext, BlockContextValue } from '~/context';

export default function Code({ children }: { children: any }) {
export default function Code({ children }: { children: ReactNode }) {
// eslint-disable-next-line react-hooks/rules-of-hooks
const blockContext = useContext(BlockContext);
Asymtode712 marked this conversation as resolved.
Show resolved Hide resolved
return (
Expand Down
19 changes: 13 additions & 6 deletions components/DocTable.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,14 @@
import React from 'react';
import Link from 'next/link';

const DocTable = ({ frontmatter }: any) => {
type Frontmatter = {
Specification: string;
Published: string;
authors: string[];
Metaschema: string;
};

const DocTable = ({ frontmatter }: { frontmatter: Frontmatter }) => {
return (
<>
<div className='max-w-full mx-auto overflow-auto'>
Expand Down Expand Up @@ -30,21 +37,21 @@ const DocTable = ({ frontmatter }: any) => {
{frontmatter.Published}
</td>
</tr>
<tr className='dark:hover:bg-slate-950 hover:bg-slate-300 '>
<tr className='dark:hover:bg-slate-950 hover:bg-slate-300'>
<td className='border border-slate-400 dark:border-slate-500 p-2 text-center font-semibold'>
Authors
</td>
<td className='border border-slate-400 dark:border-slate-500 p-2'>
{frontmatter.authors.map((author: string, index: number) => {
return <div key={index}>{author}</div>;
})}
{frontmatter.authors.map((author, index) => (
<div key={index}>{author}</div>
))}
</td>
</tr>
<tr className='dark:hover:bg-slate-950 hover:bg-slate-300'>
<td className='border border-slate-400 dark:border-slate-500 p-2 text-center font-semibold'>
Metaschema
</td>
<td className='border border-slate-400 dark:border-slate-500 p-2 '>
<td className='border border-slate-400 dark:border-slate-500 p-2'>
<Link
href={frontmatter.Metaschema}
className='text-linkBlue'
Expand Down
69 changes: 49 additions & 20 deletions components/GettingStarted.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,19 +4,54 @@ import Highlight from 'react-syntax-highlighter';
import JSZip from 'jszip';
import { saveAs } from 'file-saver';

interface SchemaOption {
file: string;
name: string;
instances: InstanceOption[];
default?: boolean;
}

interface InstanceOption {
file: string;
details: string;
valid: string;
name: string;
default?: boolean;
}

interface SchemaData {
id: string;
title: string;
description: string;
}

interface InstanceData {
id: string;
title: string;
description: string;
}

async function fetchData() {
const response = await fetch('/data/getting-started-examples.json');
const data = await response.json();
const data: SchemaOption[] = await response.json();

const defaultSchemaData = data.find((data: any) => data.default === true);
const defaultSchemaData = data.find((schema) => schema.default === true);

if (!defaultSchemaData) {
throw new Error('Default schema not found');
}

const schemaResp = await fetch(defaultSchemaData.file);
const schemaData = await schemaResp.json();

const defaultInstanceData = defaultSchemaData.instances.find(
(instance: any) => instance.default === true,
(instance) => instance.default === true,
);

if (!defaultInstanceData) {
throw new Error('Default instance not found');
}

const instanceResp = await fetch(defaultInstanceData.file);
const instanceData = await instanceResp.json();

Expand All @@ -29,17 +64,6 @@ async function fetchData() {
};
}

interface SchemaOption {
file: string;
instances: InstanceOption[];
}

interface InstanceOption {
file: string;
details: string;
valid: string;
}

const GettingStarted = () => {
useEffect(() => {
fetchData()
Expand All @@ -64,8 +88,10 @@ const GettingStarted = () => {
const [options, setOptions] = useState<SchemaOption[]>([]);
const [instances, setInstances] = useState<InstanceOption[]>([]);
const [details, setDetails] = useState<string[]>(['', '']);
const [fetchedSchema, setFetchedSchema] = useState();
const [fetchedInstance, setFetchedInstance] = useState();
const [fetchedSchema, setFetchedSchema] = useState<SchemaData | null>(null);
const [fetchedInstance, setFetchedInstance] = useState<InstanceData | null>(
null,
);

const handleSchemaChange = async (
e: React.ChangeEvent<HTMLSelectElement>,
Expand All @@ -86,7 +112,7 @@ const GettingStarted = () => {
setFetchedInstance(instData);
} else {
setInstances([]);
setFetchedSchema(null!);
setFetchedSchema(null);
}
};

Expand All @@ -104,7 +130,7 @@ const GettingStarted = () => {
setFetchedInstance(instanceData);
setDetails([selectedInstance.details, selectedInstance.valid]);
} else {
setFetchedInstance(undefined);
setFetchedInstance(null);
}
};

Expand All @@ -125,6 +151,7 @@ const GettingStarted = () => {
return (
<>
<div className='relative'>
{/* Schema Select and Display */}
<div className='flex flex-col'>
<div className='flex items-end flex-row justify-between mt-5 mb-3 '>
<h2 className='text-h6 font-semibold mb-1'>JSON Schema</h2>
Expand All @@ -138,7 +165,7 @@ const GettingStarted = () => {
id='Examples'
onChange={handleSchemaChange}
>
{options.map((option: any, id: number) => (
{options.map((option, id) => (
<option key={id} value={option.file}>
{option.name}
</option>
Expand Down Expand Up @@ -180,6 +207,7 @@ const GettingStarted = () => {
</div>
</div>

{/* Instance Select and Display */}
<div className='flex flex-col'>
<div className='flex items-end flex-row justify-between mt-5 mb-3 '>
<h2 className='text-h6 font-semibold mb-1'>JSON Instance</h2>
Expand All @@ -193,7 +221,7 @@ const GettingStarted = () => {
id='Examples'
onChange={handleInstanceChange}
>
{instances.map((instance: any, id: number) => (
{instances.map((instance, id) => (
<option key={id} value={instance.file}>
{instance.name}
</option>
Expand Down Expand Up @@ -244,6 +272,7 @@ const GettingStarted = () => {
</div>
</div>

{/* Download Button */}
<button
className='absolute right-0 my-4 text-[17px] bg-startBlue text-white px-3 py-1 rounded'
onClick={createZip}
Expand Down
19 changes: 15 additions & 4 deletions components/Headlines.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,19 @@ import slugifyMarkdownHeadline from '~/lib/slugifyMarkdownHeadline';
import { useRouter } from 'next/router';
import { HOST } from '~/lib/config';

// Custom data type for attributes
type Attributes = {
slug?: string;
className?: string;
onClick?: () => void;
id?: string;
'data-test'?: string;
};

// Update HeadlineProps type definition
Asymtode712 marked this conversation as resolved.
Show resolved Hide resolved
type HeadlineProps = {
children: string | React.ReactNode[];
attributes?: Record<string, any>;
attributes?: Attributes;
};

export const Headline1 = ({ children, attributes }: HeadlineProps) => (
Expand Down Expand Up @@ -37,12 +47,12 @@ const Headline = ({
}: {
children: string | React.ReactNode[];
Tag: React.FunctionComponent<TagProps>;
attributes?: Record<string, any>;
attributes?: Attributes;
Asymtode712 marked this conversation as resolved.
Show resolved Hide resolved
}) => {
const router = useRouter();
const [isActive, setIsActive] = useState<boolean>(false);
const asPath = router.asPath;
const slug = slugifyMarkdownHeadline(children as any[]);
const slug = slugifyMarkdownHeadline(children as string[]);

useEffect(() => {
const hashIndex = asPath.indexOf('#');
Expand Down Expand Up @@ -72,6 +82,7 @@ const Headline = ({
onClick: handleHeadingClick,
'data-test': 'headline',
};

const childredWithoutFragment = filterFragment(children);
return (
<Tag attributes={attributes}>
Expand All @@ -92,7 +103,7 @@ const filterFragment = (children: string | React.ReactNode[]) => {
});
};

type TagProps = { children: React.ReactNode; attributes: Record<string, any> };
type TagProps = { children: React.ReactNode; attributes: Attributes };
Asymtode712 marked this conversation as resolved.
Show resolved Hide resolved

const Headline1Tag = ({ children, attributes }: TagProps) => (
<h1
Expand Down
31 changes: 19 additions & 12 deletions components/Layout.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,11 @@ type Props = {
metaTitle?: string;
whiteBg?: boolean;
};

type StoreState = {
overlayNavigation: string | null;
};

// apiKey and appId are set in the .env.local file
const algoliaAppId: string = process.env.NEXT_PUBLIC_ALGOLIA_APP_ID as string;
const algoliaApiKey: string = process.env.NEXT_PUBLIC_ALGOLIA_API_KEY as string;
Expand All @@ -29,7 +34,9 @@ export default function Layout({
metaTitle,
whiteBg,
}: Props) {
const showMobileNav = useStore((s: any) => s.overlayNavigation === 'docs');
const showMobileNav = useStore(
(s: StoreState) => s.overlayNavigation === 'docs',
);

const router = useRouter();

Expand Down Expand Up @@ -57,7 +64,7 @@ export default function Layout({
const handleCloseNavbar = (event: MouseEvent) => {
if (
mobileNavRef.current &&
(mobileNavRef.current as any).contains(event.target)
mobileNavRef.current.contains(event.target as Node)
) {
useStore.setState({ overlayNavigation: null });
}
Expand Down Expand Up @@ -124,18 +131,16 @@ export const Search = () => {
/>
);
};
/* eslint-disable @typescript-eslint/no-unused-vars */
const MainNavLink = ({
uri,
label,
className,
isActive,
}: {

type MainNavLinkProps = {
uri: string;
label: string;
isActive: boolean;
className?: string;
}) => {
isActive: boolean;
Asymtode712 marked this conversation as resolved.
Show resolved Hide resolved
DhairyaMajmudar marked this conversation as resolved.
Show resolved Hide resolved
};

/* eslint-disable @typescript-eslint/no-unused-vars */
Asymtode712 marked this conversation as resolved.
Show resolved Hide resolved
const MainNavLink = ({ uri, label, className, isActive }: MainNavLinkProps) => {
Asymtode712 marked this conversation as resolved.
Show resolved Hide resolved
const router = useRouter();
return (
<Link
Expand All @@ -158,7 +163,9 @@ const MainNavLink = ({

const MainNavigation = () => {
const section = useContext(SectionContext);
const showMobileNav = useStore((s: any) => s.overlayNavigation === 'docs');
const showMobileNav = useStore(
(s: StoreState) => s.overlayNavigation === 'docs',
);

const { resolvedTheme, theme } = useTheme();
const [icon, setIcon] = useState('');
Expand Down
35 changes: 9 additions & 26 deletions components/NextPrevButton.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,36 +2,19 @@ import Image from 'next/image';
import React from 'react';
import Link from 'next/link';

/*
To use this component:
1) Add prev and next metadata to the markdown page following this format:

---
title: Creating your first schema
section: docs
prev:
label: prev
url: '#1'
next:
label: Miscellaneous examples
url: '#2'
---

2) Add the component to the typescript page:

import NextPrevButton from '~/components/NextPrevButton';

3) Add the component to the body of the page:

<NextPrevButton prevLabel={frontmatter.prev.label} prevURL={frontmatter.prev.url} nextLabel={frontmatter.next.label} nextURL={frontmatter.next.url} />
*/
type NextPrevButtonProps = {
prevLabel: string;
prevURL: string;
nextLabel: string;
nextURL: string;
};

export default function NextPrevButton({
prevLabel,
prevURL,
nextLabel,
nextURL,
}: any) {
}: NextPrevButtonProps) {
return (
<div className='mb-4 flex flex-row gap-4'>
<div className='h-auto w-1/2'>
Expand Down Expand Up @@ -60,12 +43,12 @@ export default function NextPrevButton({
<div className='h-auto w-1/2'>
<div className='h-full cursor-pointer rounded border border-gray-200 p-4 text-center shadow-md transition-all duration-300 ease-in-out hover:border-gray-300 hover:shadow-lg dark:shadow-xl dark:drop-shadow-lg dark:hover:shadow-2xl lg:text-right'>
<Link href={nextURL}>
<div className='text-primary dark:text-slate-300 flex flex-row-reverse gap-5 text-[18px]'>
<div className='text-primary dark:text-slate-300 flex flex-row-reverse gap-5 text-[18px]'>
<Image
src={'/icons/arrow.svg'}
height={10}
width={10}
alt='next icon '
alt='next icon'
className='w-5'
/>
<div className='my-auto inline font-bold uppercase '>Up Next</div>
Expand Down
2 changes: 1 addition & 1 deletion next-env.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
/// <reference types="next/image-types/global" />

// NOTE: This file should not be edited
// see https://nextjs.org/docs/basic-features/typescript for more information.
// see https://nextjs.org/docs/pages/building-your-application/configuring/typescript for more information.
Loading
Loading