[Fix]: Fixed Navbar dark mode navigation

[officeneerajsaini]

This Pull Request Fixes the Navbar Navigation Color in Dark mode.

Issue Number:

• Closes 🐛 Bug: Some Section need's Improvement #1057

Screenshots/videos:
Before:

Screen.Recording.2024-10-24.at.10.51.20.AM.mov

After :

Screen.Recording.2024-10-24.at.10.52.49.AM.mov

[officeneerajsaini]

In macOS, I'm encountering another issue with the Navbar search button. The search button's style contains a background-color property.

[officeneerajsaini]

[github-actions]

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name	Status	Preview	Last Commit
website	✅ Ready (View Log)	Visit Preview	711decc

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (7ecd915) to head (711decc).
Report is 8 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main     #1059   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          373       373           
  Branches        94        94           
=========================================
  Hits           373       373           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[officeneerajsaini]

I'm sorry for making this pull request complex for the reviewer. Initially, I did my work well, but the package-lock.json and yarn.lock files were included. Then I made another commit, and I wanted to combine both commits into a single one. Due to some issues, I deleted my branch and then restored it. Now, I've combined both commits into one, but it also includes the previous merged commit. That's what has been happening with me.

[DhairyaMajmudar]

I'm sorry for making this pull request complex for the reviewer. Initially, I did my work well, but the package-lock.json and yarn.lock files were included. Then I made another commit, and I wanted to combine both commits into a single one. Due to some issues, I deleted my branch and then restored it. Now, I've combined both commits into one, but it also includes the previous merged commit. That's what has been happening with me.

No worries with that just remove the changes from yarn.lock and package.json files.

[officeneerajsaini]

I'm sorry for making this pull request complex for the reviewer. Initially, I did my work well, but the package-lock.json and yarn.lock files were included. Then I made another commit, and I wanted to combine both commits into a single one. Due to some issues, I deleted my branch and then restored it. Now, I've combined both commits into one, but it also includes the previous merged commit. That's what has been happening with me.

No worries with that just remove the changes from yarn.lock and package.json files.

Yeah I did 😄

[officeneerajsaini]

The commit #1049 is also included in my pull request.

[DhairyaMajmudar]

Seems like there are still some more changes left to be removed : )

[officeneerajsaini]

What should I do now then, that commit already merged with that code.

[DhairyaMajmudar]

From here too

[officeneerajsaini]

@DhairyaMajmudar Please Review Code now.

[DhairyaMajmudar]

@officeneerajsaini pls. don't change the font colors

[officeneerajsaini]

@officeneerajsaini pls. don't change the font colors

In dark mode, some light colors look better than a dark-on-dark combination.

Consistent color:

Screen.Recording.2024-10-25.at.11.26.19.AM.mov

Some Lightness :

Screen.Recording.2024-10-25.at.11.25.50.AM.mov

Should I go with the website theme color?

[benjagm]

Looks great, Thanks!!

However I do prefer the white color for the navbar fonts instead that light grey. Can we change that?

[officeneerajsaini]

Looks great, Thanks!!

However I do prefer the white color for the navbar fonts instead that light grey. Can we change that?

Yes, and what about the color for the active and hover effects?