-
-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix]: Fixed Navbar dark mode navigation #1059
base: main
Are you sure you want to change the base?
[Fix]: Fixed Navbar dark mode navigation #1059
Conversation
In macOS, I'm encountering another issue with the Navbar search button. The search button's style contains a background-color property. |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1059 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 373 373
Branches 94 94
=========================================
Hits 373 373 ☔ View full report in Codecov by Sentry. |
Bumps [husky](https://github.com/typicode/husky) from 9.1.5 to 9.1.6. - [Release notes](https://github.com/typicode/husky/releases) - [Commits](typicode/husky@v9.1.5...v9.1.6) --- updated-dependencies: - dependency-name: husky dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> fixed navbar dark mode navigation fixed fixed
d495e6d
to
1dfe08f
Compare
I'm sorry for making this pull request complex for the reviewer. Initially, I did my work well, but the |
No worries with that just remove the changes from |
Yeah I did 😄 |
The commit #1049 is also included in my pull request. |
package.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like there are still some more changes left to be removed : )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What should I do now then, that commit already merged with that code.
yarn.lock
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From here too
@DhairyaMajmudar Please Review Code now. |
@officeneerajsaini pls. don't change the font colors |
In dark mode, some light colors look better than a dark-on-dark combination. Consistent color: Screen.Recording.2024-10-25.at.11.26.19.AM.movSome Lightness : Screen.Recording.2024-10-25.at.11.25.50.AM.movShould I go with the website theme color? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, Thanks!!
However I do prefer the white color for the navbar fonts instead that light grey. Can we change that?
Yes, and what about the color for the active and hover effects? |
This Pull Request Fixes the Navbar Navigation Color in Dark mode.
Issue Number:
Screenshots/videos:
Before:
Screen.Recording.2024-10-24.at.10.51.20.AM.mov
After :
Screen.Recording.2024-10-24.at.10.52.49.AM.mov