-
-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Incorrect Times/Timezones when fetching events #1060
base: main
Are you sure you want to change the base?
Conversation
@DhairyaMajmudar @benjagm please review |
@techmannih the build and lint workflows are failing, pls. fix them |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1060 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 373 373
Branches 94 94
=========================================
Hits 373 373 ☔ View full report in Codecov by Sentry. |
sure, please check now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @techmannih.
The times are not correct. They should be:
- JSON Schema Open Community Working Meetings should be at 19:00 UTC
- JSON Schema Office Hours (APAC/Americas) should be at 10:00 UTC
- JSON Schema Office Hours (Europe/Americas) should be at 14:00 UTC
You need to check what is the timezone of the meeting in the calendar and later convert to UTC:
- JSON Schema Open Community Working Meetings is stored in Europe/London timezone
- JSON Schema Office Hours (APAC/Americas) should be at 10:00 UTC
- JSON Schema Office Hours (Europe/Americas) should be at 14:00 UTC is stored in Europe/London is stored in America/Los_Angeles
@benjagm but in the calender these are different, Please clarify whether the time on the calendar is in the local time zone or in UTC |
What kind of change does this PR introduce?
Fixing a Bug, Incorrect Times/Timezones when fetching events from the Community calendar #1036
Issue Number:
Issue #1036
Screenshots/videos: