Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Incorrect Times/Timezones when fetching events #1060

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

techmannih
Copy link
Contributor

What kind of change does this PR introduce?
Fixing a Bug, Incorrect Times/Timezones when fetching events from the Community calendar #1036
Issue Number:
Issue #1036

Screenshots/videos:
image

@techmannih techmannih requested a review from a team as a code owner October 24, 2024 07:07
@techmannih
Copy link
Contributor Author

@DhairyaMajmudar @benjagm please review

@DhairyaMajmudar
Copy link
Member

@techmannih the build and lint workflows are failing, pls. fix them

Copy link

github-actions bot commented Oct 24, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 8f0dbcc

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (5c0ef1b) to head (8f0dbcc).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1060   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          373       373           
  Branches        94        94           
=========================================
  Hits           373       373           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@techmannih
Copy link
Contributor Author

@techmannih the build and lint workflows are failing, pls. fix them

sure, please check now

Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @techmannih.

The times are not correct. They should be:

  • JSON Schema Open Community Working Meetings should be at 19:00 UTC
  • JSON Schema Office Hours (APAC/Americas) should be at 10:00 UTC
  • JSON Schema Office Hours (Europe/Americas) should be at 14:00 UTC

You need to check what is the timezone of the meeting in the calendar and later convert to UTC:

  • JSON Schema Open Community Working Meetings is stored in Europe/London timezone
  • JSON Schema Office Hours (APAC/Americas) should be at 10:00 UTC
  • JSON Schema Office Hours (Europe/Americas) should be at 14:00 UTC is stored in Europe/London is stored in America/Los_Angeles

@techmannih
Copy link
Contributor Author

techmannih commented Oct 26, 2024

@benjagm but in the calender these are different, Please clarify whether the time on the calendar is in the local time zone or in UTCimage

@DhairyaMajmudar DhairyaMajmudar added the Hacktoberfest-accepted Pull requests accepted for Hacktoberfest'24 label Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest-accepted Pull requests accepted for Hacktoberfest'24
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants