Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented a search box on blogs page #1409

Closed

Conversation

GhostArymst
Copy link

What kind of change does this PR introduce?

Issue Number:

Screenshots/videos:

Before

image

After

image

Summary

I wanted to search for certain blog posts but there was no way to do it and the only available option right now was to filter by category. It wasn't the best plus scrolling through 8+ rows of blog posts was fine, but it might become an issue to future users of the website as pagination is also not implemented yet.

I opened issue #1408 for the same reasons. Thank you for reviewing :)

Does this PR introduce a breaking change?

No

@GhostArymst GhostArymst requested a review from a team as a code owner February 13, 2025 20:13
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the JSON Schema Community. Thanks a lot for creating your first pull request!! 🎉🎉 We are so excited you are here! We hope this is only the first of many! For more details check out README.md file.

@GhostArymst
Copy link
Author

Hi,

  1. I fixed the prettier formatting issue which was causing the lint check failing, I have fixed it.

  2. There is a new error which says that the "size" for the page \blogs is now exceeding 128 kB. I think this is because all pages are being sent at once.

Should I include pagination?

@cbum-dev
Copy link
Contributor

I think you should have waited for the issue to be assigned to you.

@GhostArymst
Copy link
Author

Oh, sorry, didn't know, will keep that in mind now.

@jagpreetrahi
Copy link

Hey @GhostArymst , You have to use 'yarn run lint --fix' command on terminal to get rid of
CI / Code Quality Checks (pull_request) fails

@jagpreetrahi
Copy link

jagpreetrahi commented Feb 16, 2025

@GhostArymst , for Build Preview Deployment / Build Preview Site and Upload Build Artifact fails , you have to remove the double quotes with single quotes for fix linting errors in 'pages/blog/index.page.tsx' . And you can also try with 'yarn run lint --fix' this cmd if it works there .

@GhostArymst
Copy link
Author

GhostArymst commented Feb 16, 2025

@jagpreetrahi I've already fixed them, they were prettier issues primarily, thanks though!

Copy link

github-actions bot commented Feb 16, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 8c57234

Copy link

codecov bot commented Feb 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (57a3894) to head (8c57234).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1409   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          387       387           
  Branches       103       103           
=========================================
  Hits           387       387           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Enhancement: Add Search Box to Blogs Page
3 participants