-
-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented a search box on blogs page #1409
Implemented a search box on blogs page #1409
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to the JSON Schema Community. Thanks a lot for creating your first pull request!! 🎉🎉 We are so excited you are here! We hope this is only the first of many! For more details check out README.md file.
Hi,
Should I include pagination? |
I think you should have waited for the issue to be assigned to you. |
Oh, sorry, didn't know, will keep that in mind now. |
Hey @GhostArymst , You have to use 'yarn run lint --fix' command on terminal to get rid of |
@GhostArymst , for Build Preview Deployment / Build Preview Site and Upload Build Artifact fails , you have to remove the double quotes with single quotes for fix linting errors in 'pages/blog/index.page.tsx' . And you can also try with 'yarn run lint --fix' this cmd if it works there . |
@jagpreetrahi I've already fixed them, they were prettier issues primarily, thanks though! |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1409 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 387 387
Branches 103 103
=========================================
Hits 387 387 ☔ View full report in Codecov by Sentry. |
What kind of change does this PR introduce?
Issue Number:
Screenshots/videos:
Before
After
Summary
I wanted to search for certain blog posts but there was no way to do it and the only available option right now was to filter by category. It wasn't the best plus scrolling through 8+ rows of blog posts was fine, but it might become an issue to future users of the website as pagination is also not implemented yet.
I opened issue #1408 for the same reasons. Thank you for reviewing :)
Does this PR introduce a breaking change?
No