Skip to content

Update information about Kotlin json-schema-validator #1440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

OptimumCode
Copy link
Contributor

This PR updates information about an existing implementation.

Please, let me know if something else is also required to update the information. Thank you!

@OptimumCode OptimumCode requested a review from a team as a code owner March 1, 2025 16:07
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the JSON Schema Community. Thanks a lot for creating your first pull request!! 🎉🎉 We are so excited you are here! We hope this is only the first of many! For more details check out README.md file.

Copy link

github-actions bot commented Mar 1, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 156b249

Copy link

codecov bot commented Mar 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (1055c7c) to head (156b249).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1440   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          387       387           
  Branches       103       103           
=========================================
  Hits           387       387           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benjagm
Copy link
Collaborator

benjagm commented Mar 2, 2025

Thanks a lor for this PR @OptimumCode . Are you the maintainer of the Validator?

@OptimumCode
Copy link
Contributor Author

Hi, @benjagm. Yes, I am

@benjagm
Copy link
Collaborator

benjagm commented Mar 2, 2025

@OptimumCode Thanks a lot for building json schema tooling!! Can I ask why replace the full link? What was wrong with the previous one?

@OptimumCode
Copy link
Contributor Author

OptimumCode commented Mar 2, 2025

Thank you for kind words, @benjagm!

It pointed to the wrong library (the validator uses kotlinx.serialization but it is not a home page for the implementation itself).
Not sure, how it happened though. I tracked the history till this commit which already has the incorrect homepage URL. The old repo contains the correct data. Probably, it was taken from a repo description accidentally (it has this url just to reference another library).

I saw a recording from the JSON scheme conference recently and remembered that the library should be on the list 😄 wanted to keep the information up-to-date.

Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this!! And thanks for growing the JSON Schema Ecosystem??

@benjagm benjagm merged commit 9b13c17 into json-schema-org:main Mar 4, 2025
13 checks passed
Copy link

github-actions bot commented Mar 4, 2025

Congratulations, @OptimumCode for your first pull request merge in this repository! 🎉🎉. Thanks for your contribution to JSON Schema!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants