Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Adding keywords page #844

Merged
merged 9 commits into from
Aug 21, 2024
Merged

Conversation

DhairyaMajmudar
Copy link
Member

@DhairyaMajmudar DhairyaMajmudar commented Aug 4, 2024

What kind of change does this PR introduce?

Adding new keywords page

Issue Number:

Screenshots/videos:
image

If relevant, did you update the documentation?
N/A

Summary

A new keywords page is added.

@DhairyaMajmudar DhairyaMajmudar requested a review from a team as a code owner August 4, 2024 06:59
Copy link

github-actions bot commented Aug 4, 2024

Hey there 👋!

Are you an implementer of a new JSON Schema related tool, or an interested user submitting a tool you like?
If so, thanks for considering adding your tool to our collection -- and if not, sorry, I'm just a bot looking at which pages you're modifying!

Someone will review your pull request shortly.

In the interim, if you haven't already, there's a few things you might be interested in reviewing or confirming:

  1. Short description: Tell us a small bit about your tool! We love staying up to date on what's out there, and what your intentions are in writing it.
  2. Come Join Our Slack!: We have an #implementers channel for anyone interested in or building JSON Schema tooling!
    An invite can be found here or on our homepage!
  3. Common Interfaces: We maintain a page with some "commonly useful programming interfaces" that tooling may want to implement and present to your users.
    You can find that page here in our documentation.
    Have a read through and consider whether you implement or should implement any of what's there.
  4. Bowtie Harness: Bowtie is a tool which gives JSON Schema users access to a huge number of different implementations across many languages, and reports on the compliance of those implementations with the JSON Schema specifications.
    If it makes sense for your kind of tool, consider writing a harness which connects it to Bowtie. Instructions for doing so can be found in the tutorial in Bowtie's documentation.

If you have any questions, any feedback, or need help with the submission process, don't hesitate to reach out.
Thanks a bunch for your awesome contribution!

Copy link

github-actions bot commented Aug 4, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview aeca747

Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great first version! Congrats. I left some comments to make some adjustments but we are very close!

data/keywords.yml Outdated Show resolved Hide resolved
data/keywords.yml Outdated Show resolved Hide resolved
pages/keywords/index.page.tsx Outdated Show resolved Hide resolved
@DhairyaMajmudar DhairyaMajmudar added the GSoD Google Season of Docs label Aug 5, 2024
Copy link

codecov bot commented Aug 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@f6dff53). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff            @@
##             main      #844   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?         1           
  Lines           ?        20           
  Branches        ?        12           
========================================
  Hits            ?        20           
  Misses          ?         0           
  Partials        ?         0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benjagm benjagm added the Status: In Progress This issue is being worked on, and has someone assigned. label Aug 13, 2024
Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Amazing job @DhairyaMajmudar !

Copy link
Member

@jdesrosiers jdesrosiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a really useful resource!

I do worry about it getting out of date as the website evolves. Is there a checklist for adding things the to website? Having something that reminds to check if this index needs to be updated would be a good idea.

@benjagm benjagm merged commit 4b0e006 into json-schema-org:main Aug 21, 2024
9 checks passed
@DhairyaMajmudar DhairyaMajmudar deleted the keywords branch September 7, 2024 14:01
@DhairyaMajmudar DhairyaMajmudar changed the title feat: adding keywords page Feat: adding keywords page Sep 8, 2024
@DhairyaMajmudar DhairyaMajmudar changed the title Feat: adding keywords page Feat: Adding keywords page Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSoD Google Season of Docs Status: In Progress This issue is being worked on, and has someone assigned.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Enhancement: It well be great to provide a keywords page
3 participants