Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update content location by transfer and add information #975

Closed
wants to merge 3 commits into from

Conversation

jagpreetrahi
Copy link

@jagpreetrahi jagpreetrahi commented Sep 24, 2024

What kind of change does this PR introduce?

This PR allows content to be updates and reorganizes the content of the Markdown files used in the JSON website.

Issue Number:
Pick one of the below options. Please remove those which don't apply.

Screenshots/videos:

Screenshot (72)
Screenshot (73)
Screenshot (74)

If relevant, did you update the documentation?

Yes, the documentation has been updated to reflect the changes made in the Markdown files.
Local Server

Summary

This change focuses on updating and moving content between Markdown files to enhance the clarity and relevance of information presented on the website. The motivation behind these updates is to provide a more cohesive user experience by reorganizing related content into more logical sections.
Issue - 187

Does this PR introduce a breaking change?

No, this PR does not introduce any breaking changes. The website's structure and functionality remain intact, ensuring a smooth user experience.

@jagpreetrahi jagpreetrahi requested a review from a team as a code owner September 24, 2024 09:00
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the JSON Schema Community. Thanks a lot for creating your first pull request!! 🎉🎉 We are so excited you are here! We hope this is only the first of many! For more details check out README.md file.

Copy link

github-actions bot commented Sep 24, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview c25f384

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d216812) to head (c25f384).
Report is 47 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #975   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          373       373           
  Branches        94        94           
=========================================
  Hits           373       373           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.gitignore Outdated
Comment on lines 63 to 66
#local file
.env
/node_modules

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

.gitignore Outdated
Comment on lines 63 to 66
#local file
.env
/node_modules

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove these changes, we already have .env and /node_modules in this file

Suggested change
#local file
.env
/node_modules

.gitignore Outdated Show resolved Hide resolved
Co-authored-by: Zeel Rajodiya <jeelrajodiyajeel@gmail.com>
@DhairyaMajmudar
Copy link
Member

@jagpreetrahi Thank you for your contribution but it seems like there's PR #963 is performing the same things done in this one. Can you pls. tell if anything is out of scope for improvement done in this, if not can you pls. mind closing it

@jagpreetrahi
Copy link
Author

Hi @DhairyaMajmudar, thank you for your response! In this issue, I aimed to provide additional details and examples, especially for non-string types, that are not currently mentioned in the official documentation. I also compared it with PR #963, and while the intention is similar, my contribution includes extra relevant information that could be helpful for developers. If these changes are useful, feel free to merge them; otherwise, I'm happy to close the issue. Please don't hesitate to reach out if any other issues arise that I can help with—I’d love to continue contributing to this organization!

@benjagm
Copy link
Collaborator

benjagm commented Oct 26, 2024

Hi @jagpreetrahi . Please apologize me as I am responsible of 2 contributors working on the same issue by mistake. You did a great work, however most of the discussion is happening in #963 therefore we are going to focus on that one.

I'd like to thank you for your time and efforts and we'd like you to join that discussion as PR reviewer therefore all the knowledge and experience you gained with this contribution will be used to make sure the other PR is great.

@jagpreetrahi
Copy link
Author

Hi @benjagm, hope you’re doing well ! No need to worry about any of it— I appreciate the opportunity to review and discuss #963 further. I’m working with the team to make improvements to the docs for our organization, aiming to get it done as soon as possible. Let’s keep collaborating to make this even better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Format is not only allowed for string values
4 participants